Bug 446639

Summary: Breeze GTK: Regression in various GTK assets since commit c18f2a472a654b648fb9e056f4c7c66d5e1bf786
Product: [Plasma] Breeze Reporter: Guillaume Castagnino <casta+kde>
Component: gtk themeAssignee: Janet Blackquill <uhhadd>
Status: RESOLVED FIXED    
Severity: normal CC: nate, plasma-bugs-null
Priority: NOR Keywords: regression
Version First Reported In: 5.23.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.23.5
Sentry Crash Report:
Attachments: 0001-gtk3-custom-GTK-properties-are-case-sensitive.patch

Description Guillaume Castagnino 2021-12-07 20:05:01 UTC
Created attachment 144321 [details]
0001-gtk3-custom-GTK-properties-are-case-sensitive.patch

GTK 3 specific CSS properties are case sensitive. Prettier in commit c18f2a472a654b648fb9e056f4c7c66d5e1bf786 made those properties lower case, thus breaking things.
For example, scrollbars steppers.

Find attached a patch to apply on top of breeze-gtk sources that fixes this issue (I wanted to open a MR, but I’m no allowed to do it)

Thank’s!
Comment 1 Nate Graham 2021-12-07 21:29:16 UTC
Oops.

Thanks for this! However you should be able to open a merge request. You just have to fork the repo on https://invent.kde.org (not GitHub), make a branch, push a commit with this change to your branch, and open the merge request. Instructions can be found at https://community.kde.org/Infrastructure/GitLab, and I'm available to help if you get stuck.
Comment 2 Guillaume Castagnino 2021-12-08 06:37:56 UTC
Ok I did not see the fork button, and my MR by mail was rejected.
Should be ok now: https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/34
Comment 3 Nate Graham 2021-12-08 16:41:14 UTC
Great!
Comment 4 Nate Graham 2021-12-24 17:57:25 UTC
Fixed by Guillaume Castagnino with https://invent.kde.org/plasma/breeze-gtk/-/commit/3785faebac7dc1541222a755e3070a8bddcc72d4 in Plasma 5.23.5!