Bug 446578

Summary: Buttons "Annotate", ""Export", "Copy Image to Clipboard", "Save As" are active when no any very first capture was made
Product: [Applications] Spectacle Reporter: Piotr Mierzwinski <piotr.mierzwinski>
Component: GeneralAssignee: Boudhayan Gupta <me>
Status: RESOLVED FIXED    
Severity: normal CC: antonio.prcela, bharadwaj.raju777, kde, nate, nicolas.fella, piotr.mierzwinski
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/spectacle/commit/86d5227eefaae0c8bb5f3c57b85bf5c81a67b65b Version Fixed In: 21.12.1
Sentry Crash Report:

Description Piotr Mierzwinski 2021-12-06 20:51:38 UTC 
SUMMARY
I set "Do not take a screenshot  automatically" in "configure -> General -> When launching Spectacle" and restarted application. No any capture has been made, but buttons related with screenshot were active, which seems doesn't make sense.

STEPS TO REPRODUCE
1. set "Do not take a screenshot  automatically" in "configure -> General -> When launching Spectacle"
2. restart application
3. check buttons "Annotate", ""Export", "Copy Image to Clipboard", "Save As"

OBSERVED RESULT
Buttons related with screenshot so: "Annotate", ""Export", "Copy Image to Clipboard", "Save As" are active.

EXPECTED RESULT
Buttons  "Annotate", ""Export", "Copy Image to Clipboard", "Save As" should not be active if not any capture happened after start application.


SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition,  updated today (06/12/2021) ~8pm
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Kernel Version: 5.14.15-051415-generic (64-bit)
Graphics Platform: X11
Memory: 7,6 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

Neon unstable updated today (06/12/2021) ~8pm

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2021-12-07 03:44:20 UTC 
We just fixed this for the Annotate button in https://invent.kde.org/graphics/spectacle/-/commit/c22deff04ec54f16c64871d0294a3f9443b282e3, but you're right, and we should probably disable the others too.
Comment 2 Bug Janitor Service 2021-12-07 20:38:07 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/107
Comment 3 Antonio Prcela 2021-12-13 21:04:43 UTC 
Git commit 86d5227eefaae0c8bb5f3c57b85bf5c81a67b65b by Antonio Prcela.
Committed on 13/12/2021 at 13:24.
Pushed by ngraham into branch 'release/21.12'.

Disable buttons that shouldn't be available when no screenshot was taken

M  +14   -5    src/Gui/KSMainWindow.cpp
M  +1    -0    src/Gui/KSMainWindow.h

https://invent.kde.org/graphics/spectacle/commit/86d5227eefaae0c8bb5f3c57b85bf5c81a67b65b