Summary: | crash during audio file metadata import | ||
---|---|---|---|
Product: | [Applications] tellico | Reporter: | mark <mark> |
Component: | general | Assignee: | Robby Stephenson <robby> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | 3.4.2 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/office/tellico/commit/0df7001533b578ababdddd8427bf1addc267003d | Version Fixed In: | 3.4.3 |
Attachments: | podcast file that will crash tellico |
Description
mark
2021-12-06 13:11:50 UTC
Any chance you could narrow down the particular audio file that might be causing the crash? There was a fair bit of updates in the audio file importer for 3.4.2, but just from looking at the code, everything seems to be correct, so I'm missing the cause of the crash somehow. If not the specific audio file, could you install the debug symbols so the debug trace could tell me more specifically what area of the code might be causing the crash? Thanks! (In reply to Robby Stephenson from comment #1) > If not the specific audio file, could you install the debug symbols so the > debug trace could tell me more specifically what area of the code might be > causing the crash? To be clear, your bug report was great since it included the stack trace. I just can't tell which line in in Tellico::Import::AudioFileImporter::collection() is crashing, so a trace with the line numbers (a "full trace") would be invaluable if you're able to generate it. i will try to narrow down which file and attempt to install debug symbols. I'm closing this. I shouldn't have been in a rush and did what i should have by narrowing down what file(s) were causing the issue. turned out i forgot about old podcast files that were generated by clementine which i no longer use. it seems clementine had added tags and that was causing this to crash. i've since switched to strawberry player. there are no issues with the files that have tags updated by musicbrainz (In reply to mark from comment #4) > I'm closing this. I shouldn't have been in a rush and did what i should > have by narrowing down what file(s) were causing the issue. turned out i > forgot about old podcast files that were generated by clementine which i no > longer use. it seems clementine had added tags and that was causing this to > crash. i've since switched to strawberry player. there are no issues with > the files that have tags updated by musicbrainz Well, Tellico still shouldn't crash, no matter what files are used. Could you send me an example of one of those old podcast files? Created attachment 144388 [details]
podcast file that will crash tellico
warning: contents of podcast for mature listener only
I had deleted all those files so i went and restored from my backup. I attached the smallest file i had that would cause the crash. You are right, a file shouldn't cause a crash even if it is bad data. good luck Git commit 0df7001533b578ababdddd8427bf1addc267003d by Robby Stephenson. Committed on 11/12/2021 at 21:43. Pushed by rstephenson into branch '3.4'. Avoid dereferencing the first value in an empty string list a TagLib::PropertyMap returns a StringList as a value, but checking if the map contains the key, is not sufficient to ensure the string list is not empty. Also, optimize a bit to avoid additional conversions to TagLib::String FIXED-IN: 3.4.3 M +4 -0 ChangeLog M +27 -12 src/translators/audiofileimporter.cpp https://invent.kde.org/office/tellico/commit/0df7001533b578ababdddd8427bf1addc267003d A possibly relevant merge request was started @ https://invent.kde.org/office/tellico/-/merge_requests/4 Git commit 9d450037f708cc2300d2767e5171bb08e48077a9 by Andreas Sturmlechner, on behalf of Lars Wendler. Committed on 09/01/2022 at 16:56. Pushed by rstephenson into branch 'master'. Fix build without HAVE_TAGLIB Gentoo-bug: https://bugs.gentoo.org/830806 M +2 -0 src/translators/audiofileimporter.cpp https://invent.kde.org/office/tellico/commit/9d450037f708cc2300d2767e5171bb08e48077a9 Git commit 46a51a04707066050f2cd2c352b15603df5dd9cf by Robby Stephenson, on behalf of Lars Wendler. Committed on 09/01/2022 at 17:06. Pushed by rstephenson into branch '3.4'. Fix build without HAVE_TAGLIB Gentoo-bug: https://bugs.gentoo.org/830806 M +2 -0 src/translators/audiofileimporter.cpp https://invent.kde.org/office/tellico/commit/46a51a04707066050f2cd2c352b15603df5dd9cf |