Bug 446424

Summary: Text line height goes crazy
Product: [Applications] krita Reporter: acc4commissions
Component: Tool/TextAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73, griffinvalley
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: All   
Latest Commit: https://invent.kde.org/graphics/krita/commit/a6d283d51581cbbf3eaef1015c0eace0c6b8f586 Version Fixed/Implemented In:
Sentry Crash Report:

Description acc4commissions 2021-12-03 15:03:42 UTC 
SUMMARY
nightly git 357aff9


STEPS TO REPRODUCE
1. create a text with more than 2 lines
2. switch back and forth between Rich text and SVG Source in the text editor

OBSERVED RESULT
The line height of the text shrinks every time you do that. It also happens when you simply re-open the text editor to edit any text.

EXPECTED RESULT
There should be no difference.

SOFTWARE/OS VERSIONS
Windows: Win10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 wolthera 2021-12-03 15:07:32 UTC 
Another victim of the dpi-workaround. I'll see if I can pin it down in a bit.
Comment 2 Dmitry Kazakov 2021-12-06 09:31:31 UTC 
Git commit ccf683b32fbb1a1786decf54f92caf3b8daf5b2d by Dmitry Kazakov.
Committed on 06/12/2021 at 09:31.
Pushed by dkazakov into branch 'master'.

Fix round trip problems with line hights in the text shape editor

M  +13   -7    libs/flake/text/KoSvgTextShapeMarkupConverter.cpp

https://invent.kde.org/graphics/krita/commit/ccf683b32fbb1a1786decf54f92caf3b8daf5b2d
Comment 3 Dmitry Kazakov 2021-12-06 09:32:11 UTC 
Git commit a6d283d51581cbbf3eaef1015c0eace0c6b8f586 by Dmitry Kazakov.
Committed on 06/12/2021 at 09:32.
Pushed by dkazakov into branch 'krita/5.0'.

Fix round trip problems with line hights in the text shape editor
(cherry picked from commit ccf683b32fbb1a1786decf54f92caf3b8daf5b2d)

M  +13   -7    libs/flake/text/KoSvgTextShapeMarkupConverter.cpp

https://invent.kde.org/graphics/krita/commit/a6d283d51581cbbf3eaef1015c0eace0c6b8f586