Bug 446352

Summary:	field pop-ups located weirdly, "##WARNING: Wayland does not support QWindow::requestActivate()", sometimes hangs
Product:	[Applications] skrooge	Reporter:	skierpage <skierpage>
Component:	general	Assignee:	Guillaume DE BURE <guillaume.debure>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	stephane
Priority:	NOR
Version:	Trunk from git
Target Milestone:	25.1.0
Platform:	Flatpak
OS:	Linux
Latest Commit:	https://invent.kde.org/office/skrooge/commit/c7fd9964a103642227916a9eca71851795f5fa37	Version Fixed In:
Sentry Crash Report:

Description skierpage 2021-12-02 00:48:21 UTC

SUMMARY
I'm running the nightly Skrooge Flatpak in Fedora 35 KDE spin, which defaults to Wayland. Skrooge broadly works, but
1) The list of choices that pops up when you start entering in a field that shows matching previous field entries sometimes appears as a separate window positioned far away, e.g. in the corner of the display, instead of directly under the field in which you're typing. When this happens the terminal where I started the Flatpak displays several warnings:
##WARNING: Wayland does not support QWindow::requestActivate()

2) Possibly at the same time, sometimes the Flatpak window will go unresponsive, turn a "bleached gray" (I think this is a KWin thing), and eventually crash. But not every time. When I restart Skrooge, it warns it's recovered data, and I've never lost any entry (👍❣️).

STEPS TO REPRODUCE
1. Enter a new operation, in Standard mode
2. Start typing a payee
3. Backspace, then start paying again

OBSERVED RESULT
The first time, a pop-up appears under the Payee text field showing previous matching payees. When you backspace to clear the field, this goes away. All good. But if I type something new, then a separate top-level Wayland window titled "Skrooge" appears showing previous matches, positioned in a corner (where other top-level Skrooge windows appear, like its initial splash window). Skrooge repeatedly alternates the good pop-up and bad top-level window if I repeat steps 2 and 3. Sometimes the top-level window will stop appearing, but if I enter in a different field like Comments it will start alternating again.

I haven't figured out how to cause the crash. There's no abrt dialog or notification of a crash. It looks like KWin is detecting the window is unresponsive, drawing it "bleached", and maybe quitting it.

EXPECTED RESULT
The pop-up should always appear underneath, never as a separate top-level window.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88
Qt Version: 5.15.3 on Wayland

ADDITIONAL INFORMATION
Maybe the window hang and crash is unrelated.

Comment 1 skierpage 2021-12-07 21:19:26 UTC

It happened again, this time clicking the [...] in Operations to clear "pointed" status did nothing... [no response]... crash. The console printed
> exit 139
which I think is "interrupted by signal 11: SIGSEGV".

Comment 2 skierpage 2021-12-23 07:45:34 UTC

Skrooge nightly flatpak version 2.27.0 has crashed on me 4 times in 1 hour ☹

Comment 3 Stephane MANKOWSKI 2022-02-19 21:21:27 UTC

Git commit c7fd9964a103642227916a9eca71851795f5fa37 by Stephane MANKOWSKI.
Committed on 19/02/2022 at 21:21.
Pushed by smankowski into branch 'master'.

field pop-ups located weirdly, "##WARNING: Wayland does not support QWindow::requestActivate()", sometimes hangs

M  +1    -0    CHANGELOG
M  +7    -0    skrooge/main.cpp

https://invent.kde.org/office/skrooge/commit/c7fd9964a103642227916a9eca71851795f5fa37

Comment 4 skierpage 2022-03-21 23:12:18 UTC

(In reply to Stephane MANKOWSKI from comment #3)
> https://invent.kde.org/office/skrooge/commit/c7fd9964a103642227916a9eca71851795f5fa37
This fix is intended to make Skrooge not run under Wayland even when your desktop environment uses Wayland. But it doesn't seem to work. I don't have QT_QPA_PLATFORM set; Plasma desktop has set XDG_SESSION_TYPE=wayland ; when I run the Skrooge master flatpak  it prints the fix's debug output
> ##Warning: disregarding XDG_SESSION_TYPE=wayland
> ##To use wayland anyway, please set QT_QPA_PLATFORM=wayland
and yet, Help > About Skrooge > Components displays "The wayland windowing system".
This is with the flatpak "Built on Sun Mar 20 13:32:19 CET 2022" using org.kde.Platform/x86_64/5.15 and components KDE Frameworks Version 5.88.0 and Qt Version 5.15.3.

If I unset XDG_SESSION_TYPE, then Skrooge doesn't print this warning and does use xcb (unless I set QT_QPA_PLATFORM as the warning suggests). Maybe the test and `qunsetenv("XDG_SESSION_TYPE")` is occurring too late in main.cpp.

Also, the CHANGELOG notice is misleading. Repeating the title of this bug makes the Wayland problem was fixed. Once the fix works, it would be better phrased as
 * Workaround: Due to issues running under Wayland (bug 446352) Skrooge defaults to using xcb unless you set QT_QPA_PLATFORM=wayland

Thanks!

Comment 5 skierpage 2022-07-19 04:14:19 UTC

I haven't seen these issues for about a month of Skrooge use running in Wayland, with newer versions of KDE and Qt. 🥳 ! No mispositioned input field pop-ups, no warnings about QWindow::requestActivate, no hangs.

Regarding comment 4,
>> https://invent.kde.org/office/skrooge/commit/c7fd9964a103642227916a9eca71851795f5fa37
> This fix is intended to make Skrooge not run under Wayland even when your desktop environment uses Wayland. 
> But it doesn't seem to work. ...
I opened bug 456895 to remove the broken override code and misleading CHANGELOG entry.