Bug 446295

Summary:	The accept dialog after changing screen resolution is not modal and is not properly set up for operation with the keyboard
Product:	[Applications] systemsettings	Reporter:	Frank Steinmetzger <dev+kde>
Component:	kcm_kscreen	Assignee:	kscreen-bugs-null <kscreen-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	christophdreier, kde, nate, plasma-bugs-null
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.23.3
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Frank Steinmetzger 2021-11-30 19:07:31 UTC

STEPS TO REPRODUCE
1. Go to display settings
2. Change screen resolution
3. A dialog pops up that tells the user that within 30 seconds the setting will revert unless it is accepted

OBSERVED RESULT
Said dialog shows the cancel button as focused, but nothing happens when I press space or enter. Or rather – I suspect the keypress goes to some widget in the settings page. Pressing TAB cycles through widgets in the main setting. This should not happen. It should cycle only through the buttons of the dialog.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.15.2-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-4590 CPU @ 3.30GHz
Memory: 31.0 GiB of RAM
Graphics Processor: AMD PITCAIRN

Comment 1 Méven Car 2021-12-17 17:35:19 UTC

Git commit 5ac4d7c6cbce0e9e0e2d143f531908d36201ea1b by Méven Car.
Committed on 17/12/2021 at 17:27.
Pushed by meven into branch 'master'.

KCM: allow to use Enter/space to revert or keep new settings

M  +12   -0    kcm/package/contents/ui/main.qml

https://invent.kde.org/plasma/kscreen/commit/5ac4d7c6cbce0e9e0e2d143f531908d36201ea1b

Comment 2 Frank Steinmetzger 2022-03-15 15:30:05 UTC

*** Bug 451274 has been marked as a duplicate of this bug. ***

Comment 3 Frank Steinmetzger 2022-03-15 15:41:07 UTC

Probably thanks to Méven's change, pressing enter works now (just tested on 5.24.3), but only if a button is focused. Well, that's correct of course, but getting there is another story:

- None of the buttons is focused by default
- focus leaves the dialog after a few presses on Tab
In essence, it's something that is made to look like a dialog, while technically it is not, bringing with it the baggage to have to reimplement expected default behaviours.

The tab order also is a bit weird when going back and forth with Tab/Shift+Tab:
- press Tab a few times initially to reach the Accept button
- press Tab again, the Accept button is still focused
- press Tab once more, and now the Revert button is focused
- in the other direction (with Shift+Tab) the focus stays on the Accept button for only one cycle.

Comment 4 Nate Graham 2022-03-15 21:27:07 UTC

(In reply to Frank Steinmetzger from comment #3)
> In essence, it's something that is made to look like a dialog, while
> technically it is not, bringing with it the baggage to have to reimplement
> expected default behaviours.
An accurate assessment.

Comment 5 Christoph Dreier 2025-09-10 23:21:49 UTC

This is still very much an existing bug in the current Plasma 6.4.4.

I would like to nominate this for the 15-minute bug initiative, as it definitely took me less than 15 minutes before my keyboard based HTPC setup came to a complete halt while I had to pull out and connect my bluetooth mouse just for that one click.