| Summary: | KPA git master crashes in viewer - only on one PC & user, not on the other ... | ||
|---|---|---|---|
| Product: | [Applications] kphotoalbum | Reporter: | Andreas Schleth <schleth_es> |
| Component: | Viewer | Assignee: | KPhotoAlbum Bugs <kphotoalbum-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | johannes |
| Priority: | NOR | ||
| Version First Reported In: | GIT master | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Andreas Schleth
2021-11-29 22:41:56 UTC
Hi Andreas, The assertion seems to be triggered by KPA not being able to save a video thumbnail file. This could possibly be related to bug #438128. Can you take a look at the permissions of the .videoThumbnails folder? ... and I should have read beyond the backtrace. You said, both instances of KPA are virtually identical. Does that include the build flags? With release builds, assertions are not fatal - this may be the reason why it crashes on one system but not on the other... Git commit f35b3a6246da2283da5c9102295e5b70ded461a5 by Johannes Zarl-Zierl. Committed on 29/11/2021 at 23:10. Pushed by johanneszarl into branch 'master'. Remove assertion when thumbnails could not be saved. If a (video thumbnail) image cannot be saved, issue a diagnostic instead of triggering an assertion. M +8 -6 Utilities/ImageUtil.cpp https://invent.kde.org/graphics/kphotoalbum/commit/f35b3a6246da2283da5c9102295e5b70ded461a5 Hi Johannes, great work! I wish, we could have similar response times & quality with commercial software at work (we don't). I just tested your fix: the crash is gone. We are now on v5.8.1-46-gf4b3a399 on both places and everything seems fine. (Best regards from my wife: she will use it tonight). Yes, as I said, the .thumbnails and .videothumbnails are read only for everybody else than me. On purpose. So, being a bit relaxed about being able to write into these folder seems like a good idea to me :-) I am building with a simple script called as ../doit.sh from the root folder. So the only remaining differences between the two PCs are - maybe - some missing devel-packages for optional features. Otherwise the build parameters are the same. When I like what I see in the demo, I usually install the fresh version as my "production" release. I don't mind the occasional crash, as your quick fixes make KPA better each time I find one. Best regards, Andreas my skript: # werfe alle lokalen changes weg git checkout master git reset --hard # hole die aktuelle Version git pull # setze debuginfos export CMAKE_BUILD_TYPE=RelWithDebInfo # wechsle ins build-Verz. cd build # lösche all cmake-Reste rm -rf C* c* # doit! cmake .. make -j8 # teste Demo ./kphotoalbum --demo Hi Andreas! Thanks for checking and reporting back! (Also for the kind words ;-) I'll close the bug for now because the immediate issue to you is gone... Cheers, Johannes |