Bug 446251

commit 68bb7c063f71631a4f207adca2235eb0f8d00d33
Author: Paul Floyd <pjfloyd@wanadoo.fr>
Date:   Sat Oct 9 15:01:08 2021 +0200

    FreeBSD support, patch 12
    
    coregrind modified files

Added TARGET_SIGNAL_THR = 77 to enum target_signal in coregrind/m_gdbserver/gdb/signals.h

But didn't update the static struct signals in coregrind/m_gdbserver/signals.c

/* This table must match in order and size the signals in enum target_signal
   in gdb/signals.h. */

Now the names after TARGET_SIGNAL_CANCEL are off by one.
(which could in theory make target_signal_to_name access one after the signal array)

Also coregrind/m_gdbserver/gdb/signals.h says:

   The numbering of these signals is chosen to match traditional unix
   signals (insofar as various unices use the same numbers, anyway).
   It is also the numbering of the GDB remote protocol.  Other remote
   protocols, if they use a different numbering, should make sure to
   translate appropriately.

   Since these numbers have actually made it out into other software
   (stubs, etc.), you mustn't disturb the assigned numbering. [...]

TARGET_SIGNAL_THR also isn't in gdb.

I believe we should simply remove TARGET_SIGNAL_THR from enum target_signal. Or if it really is necessary coordinate with gdb to assign it a new number.