Bug 446154

Summary:	canceling 'move files' with the stop button in the popup, leads to permanent file content loss.
Product:	[Applications] dolphin	Reporter:	kodintent <kodintent>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	critical	CC:	kdedev, kfm-devel
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description kodintent 2021-11-27 08:17:54 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

STEPS TO REPRODUCE
1. select files on usb-c connected phone, with dolphin file browser
2. drag to desired folder on computer
3. right click - accidentally select move yet again, because it is right next to copy
4. quickly press the stop button in the popup.

OBSERVED RESULT
files already moved before stop is registered, are deleted from the phone, and the copies in the destination all have 0kb size (about 10 files!). the contents of the file are permanently lost. phone files are already permanently deleted, not moved to trash. files not yet moved remain in the phone. dolphin has done nothing to verify the copy of each file before deleting the source, and has not waited to verify each single file before moving to the next one, or waited until files are verified before deleting their source. all that remains of the file is the filename.

EXPECTED RESULT
files already moved are reproduced perfectly including the file currently being moved when the stop button is pressed. files not yet moved remain in the phone. because dolphin should check that the reproduced file is at least identical in size to the one being copied from, before the original is deleted!

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 20.04
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8
Kernel Version: 5.11.0-40-generic
OS Type: 64-bit
Processors: 4 × Intel® Pentium® Silver N5030 CPU @ 1.10GHz
Memory: 7.6 GiB of RAM

ADDITIONAL INFORMATION
i immediately removed dolphin completely from my system as the first response to this permanent loss of file content. and rightly so. the version is whatever it would be in fully updated kubuntu as at the date of submitting this bug.
when move is used and not interrupted, it works as expected, as does copy. only when interrupted with stop does this bug occur.
supposedly, anyone using dolphin is exposed to permanent data loss as long as this bug exists.
my suggestion is to move the "move" option to the initial right click, not after the drag. other software that has "move to" does this and its easy to back out of wrong clicks, without permanent data loss.
i cannot help with further testing as im not coming back to dolphin, as long as the move option is where it is.

Comment 1 kodintent 2021-11-27 08:22:39 UTC

right click is in step 2, and in step 3 the popup is automatic  when the mouse button is released on the destination folder.

Comment 2 TraceyC 2024-06-13 22:19:42 UTC

Thank you for the bug report. Unfortunately we were not able to get to it yet. Can we ask you to please check if this is still an issue with either Plasma 5.27 (the current LTS version) or Plasma 6.0.5 (the latest released version)?

I attempted to reproduce this (with Plasma 6), but wasn't able to.

TEST STEPS
Connect phone to PC with USB C cable
Copy some files (mp3s) to a test folder on the phone with Dolphin (to avoid losing anything)
In Dolphin, select the files on the phone in the test folder
Drag files to a temp folder on PC, choose move
Right click the files on the phone - select move again, immediately click stop button

4 of 7 files had been moved completely to the PC. They were the complete files, not 0 byte. I verified they were OK by playing them.
The 3 files that had not yet been moved were still present on the phone with their original size. I verified they were still OK by playing them.

Comment 3 kodintent 2024-06-16 08:56:33 UTC

(In reply to TraceyC from comment #2)
> Thank you for the bug report. Unfortunately we were not able to get to it
> yet. Can we ask you to please check if this is still an issue with either
> Plasma 5.27 (the current LTS version) or Plasma 6.0.5 (the latest released
> version)?
> 
> I attempted to reproduce this (with Plasma 6), but wasn't able to.
> 
> TEST STEPS
> Connect phone to PC with USB C cable
> Copy some files (mp3s) to a test folder on the phone with Dolphin (to avoid
> losing anything)
> In Dolphin, select the files on the phone in the test folder
> Drag files to a temp folder on PC, choose move
> Right click the files on the phone - select move again, immediately click
> stop button
> 
> 4 of 7 files had been moved completely to the PC. They were the complete
> files, not 0 byte. I verified they were OK by playing them.
> The 3 files that had not yet been moved were still present on the phone with
> their original size. I verified they were still OK by playing them.

Hi.
thanks for your attention to this bug report.
Im no longer using linux desktop on any of my devices, and at this time i wont reinstall linux to help with testing, sorry.
if people are still experiencing this issue, surely it will be reported. If not, then its likely too rare to worry about.
kodintent.

Comment 4 TraceyC 2024-06-17 15:01:28 UTC

Closing, since the bug can't be reproduced.