Bug 446128

Summary: KDE connect builds for OSX has been broken.
Product: [Applications] kdeconnect Reporter: idoitprone <monkeyboyted>
Component: commonAssignee: Albert Vaca Cintora <albertvaka>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
URL: https://binary-factory.kde.org/view/MacOS/job/kdeconnect-kde_Nightly_macos/
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Build 1348 logs
Build 1357 logs

Description idoitprone 2021-11-26 18:57:52 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

The factory build has been broken for over two weeks. Logs throws a wide variety of errors. The build server create the last dmg file on November 14. I will have to report a separate bug because the dmg does not mount.

https://binary-factory.kde.org/view/MacOS/job/kdeconnect-kde_Nightly_macos/

STEPS TO REPRODUCE
1. Wait one day. 
2. Build fails


OBSERVED RESULT
No binary is created

EXPECTED RESULT
DMG is created.

SOFTWARE/OS VERSIONS
macOS: Any
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 idoitprone 2021-11-26 19:00:14 UTC 
Created attachment 143978 [details]
Build 1348 logs

Nov 16
Comment 2 idoitprone 2021-11-26 19:02:28 UTC 
Created attachment 143979 [details]
Build 1357 logs

Nov 26
Comment 3 idoitprone 2021-11-26 19:38:24 UTC 

This log might have a clue.

07:26:06  In file included from /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.mm:40:
07:26:06  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h:54:32: error: unknown type name 'CGColorSpaceRef'; did you mean 'QColorSpace'?
07:26:06      void setColorSpace(QCFType<CGColorSpaceRef> colorSpace);
07:26:06                                 ^~~~~~~~~~~~~~~
07:26:06                                 QColorSpace
07:26:06  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/include/QtCore/../../src/corelib/kernel/qmetatype.h:2090:1: note: 'QColorSpace' declared here
07:26:06  QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)
07:26:06  ^
07:26:06  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/include/QtCore/../../src/corelib/kernel/qmetatype.h:178:24: note: expanded from macro 'QT_FOR_EACH_STATIC_GUI_CLASS'
07:26:06      F(QColorSpace, 87, QColorSpace) \
07:26:06                         ^
07:26:06  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.mm:90:32: error: out-of-line definition of 'setColorSpace' does not match any declaration in 'QIOSurfaceGraphicsBuffer'
07:26:06  void QIOSurfaceGraphicsBuffer::setColorSpace(QCFType<CGColorSpaceRef> colorSpace)
07:26:06                                 ^~~~~~~~~~~~~
07:26:06  /Users/packaging/Craft/BinaryFactory/macos-64-clang/build/libs/qt5/qtbase/work/qtbase-everywhere-src-5.15.2/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h:54:24: note: type of 1st parameter of member declaration does not match definition ('QCFType<QColorSpace>' vs 'QCFType<CGColorSpaceRef>')
07:26:06      void setColorSpace(QCFType<CGColorSpaceRef> colorSpace);
07:26:06                         ^
07:26:06  2 errors generated.
07:26:06  make[4]: *** [.obj/qiosurfacegraphicsbuffer.o] Error 1
07:26:06  make[4]: *** Waiting for unfinished jobs....
07:26:09  make[3]: *** [sub-cocoa-make_first] Error 2
07:26:09  make[2]: *** [sub-platforms-make_first] Error 2
07:26:09  make[1]: *** [sub-plugins-make_first] Error 2
07:26:09  make: *** [sub-src-make_first] Error 2
07:26:09  Command ['/usr/bin/make', '-j', '4'] failed with exit code 2
07:26:09  Action: compile for libs/qt5/qtbase:5.15.2-6 FAILED
07:26:09  *** Craft all failed: libs/qt5/qtbase after 25 minutes 49 seconds ***
07:26:09  fatal error: package libs/qt5/qtbase all failed


https://github.com/microsoft/vcpkg/issues/21055
https://github.com/bitcoin/bitcoin/pull/23580/files
https://code.qt.io/cgit/qt/qtbase.git/commit/src/plugins/platforms/cocoa?id=dece6f5840463ae2ddf927d65eb1b3680e34a547

It seems like Apple refactored something and qt needs to add an header. 

diff --git a/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h b/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
index 5d4b6d6a71..cc7193d8b7 100644
--- a/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
+++ b/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h
@@ -43,6 +43,7 @@
 #include <qpa/qplatformgraphicsbuffer.h>
 #include <private/qcore_mac_p.h>
 
+#include <CoreGraphics/CGColorSpace.h>
 #include <IOSurface/IOSurface.h>
 
 QT_BEGIN_NAMESPACE
Comment 4 idoitprone 2021-12-13 19:48:49 UTC 
I checked today and I could not find the first build that works. The earlier build I can see is #1365.

https://binary-factory.kde.org/view/MacOS/job/kdeconnect-kde_Nightly_macos/

This bug is resolved.