Bug 446050

Summary: ECMGenerateQmlTypes generates plugins.qmltypes in source directory which is incompatible with CMAKE_DISABLE_SOURCE_CHANGES
Product: [Frameworks and Libraries] extra-cmake-modules Reporter: Dawid Wróbel <me>
Component: generalAssignee: ecm-bugs-null <ecm-bugs-null>
Status: ASSIGNED ---    
Severity: normal    
Priority: NOR    
Version First Reported In: 5.88.0   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Dawid Wróbel 2021-11-24 21:39:58 UTC 
SUMMARY

The ECMGenerateQmlTypes says in its description:

"The developer will be in charge of making sure that these files are up to date. The plugin.qmltypes file will sit in the source directory."

Which implies that it should be the developer themselves that need to keep this file up to date. However, the file is being generated by each CMake passing and saved in the source code, which makes it immediately incompatible with CMAKE_DISABLE_SOURCE_CHANGES.

Moreover, this seems to argue with another default behavior, which installs the auto-generated file to a final location:

"This function will include the code that installs the file in the right place"

At this point, is it even necessary to modify the source code, if the file is being always regenerated and that copy is installed?
Comment 1 Bug Janitor Service 2021-11-24 21:46:58 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/201