Bug 446023

Summary:	Transform tool with "Fast" preview does not update or insert keyframes for an animated transform mask
Product:	[Applications] krita	Reporter:	CompactingHansom
Component:	Animation	Assignee:	Eoin O'Neill <eoinoneill1991>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard, eoinoneill1991
Priority:	NOR
Version First Reported In:	5.0.0-beta2
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/270948d8f240fe28abd9e0d378de2eeb7a2da016	Version Fixed/Implemented In:
Sentry Crash Report:

Description CompactingHansom 2021-11-24 10:28:28 UTC

SUMMARY

When the transform tool has its Preview set to "Fast" then transformations do not stick when transforming an animated transform mask.  Both "Accurate" and "Accurate with Instant Preview" work fine.

STEPS TO REPRODUCE
1. Create a paint layer to animate
2. Add a transform mask
3. Add a keyframe for said mask under animation curves
4. Choose the transform tool
5. Set the preview to Fast
6. Transform the mask
7. Hit enter or select a different frame

OBSERVED RESULT
The values in the animation curve docker do not change and the transformation is reverted.

EXPECTED RESULT
The values in the animation curve docker should change as I transform the mask (or at least upon hitting enter) and the new transformation should be preserved as a keyframe.

SOFTWARE/OS VERSIONS
Kubuntu 21.04
Linux: 5.11.0-40-generic
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Took me almost an hour of trying to follow video tutorials to realize I wasn't doing it wrong; I had just previously changed the preview to Fast for some reason and forgotten about it.

Comment 1 Ahab Greybeard 2021-11-26 18:40:54 UTC

I can confirm this for the 5.0.0-beta2 and the Nov 26 5.1.0-prealpha (git 4a272ff) appimages on Debian 10.
It seems that 5.0.0-beta1 does not have this functionality.

Comment 2 Eoin O'Neill 2022-01-13 03:06:00 UTC

Git commit 270948d8f240fe28abd9e0d378de2eeb7a2da016 by Eoin O'Neill.
Committed on 13/01/2022 at 03:03.
Pushed by eoinoneill into branch 'master'.

Fix "Fast" Transform preview mode not creating or modifying keyframe data for transform masks.

Should now work the same as inplace transform mode for the most part. Values do not change
in real time due to the way fast mode works, and values will change after being moved to
the desired location. This should keep operation uninterrupted and fast (as intended..)

M  +24   -0    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/commit/270948d8f240fe28abd9e0d378de2eeb7a2da016