Bug 445756

Summary:	Emblem icon colors are inverted when using Breeze Dark color scheme
Product:	[Plasma] Breeze	Reporter:	Grzesiek11 <grzesiek11>
Component:	Icons	Assignee:	visual-design
Status:	RESOLVED INTENTIONAL
Severity:	minor	CC:	andreas_k, kainz.a, nate
Priority:	NOR	Keywords:	regression
Version:	5.23.3
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=445518
Latest Commit:		Version Fixed In:

Description Grzesiek11 2021-11-19 16:35:35 UTC

SUMMARY
After the upgrade to KDE Frameworks 5.88, some emblem icons (including the emblems on folder icons) have inverted colors. This looks really weird and also is broken in some programs (ex. QuasselIRC). This doesn't affect the icon picker itself, in which icons look the same on both color schemes (expected result).

STEPS TO REPRODUCE
1. Change the system color scheme to Breeze or Breeze Light.
2. Create a folder.
3. Set it's icon to, for example, 'folder-music' via the Properties menu in Dolphin.
4. Notice how the icon looks normal.
5. Change the system color scheme to Breeze Dark.

OBSERVED RESULT
The emblem on the folder icon has inverted colors.

EXPECTED RESULT
The emblem on the folder icon stays the same.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.2
Kernel Version: 5.14.0-18.1-liquorix-amd64 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-2400 CPU @ 3.10GHz
Memory: 11.7 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 660/PCIe/SSE2

ADDITIONAL INFORMATION
Screenshots for reference:
- Dolphin (Breeze Light, correct): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_165959.png
- Dolphin (Breeze Dark, incorrect): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_165934.png
- Icon picker (Breeze Dark, correct): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170121.png
- QuasselIRC (Breeze Light, correct): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170028.png
- QuasselIRC (Breeze Dark, incorrect; notice how most icons are almost invisible): https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170049.png

Comment 1 Nate Graham 2021-11-19 16:47:46 UTC

Looks like there are a few issues here.

The colorful folder emblem is one.

The monochrome icons being inverted is probably Bug 445489.

Let's use this to track the issue of the emblems changing color unexpectedly, which I can reproduce.

Comment 2 Nate Graham 2021-11-19 16:48:10 UTC

...Unless that was an intentional change, of course. Hopefully Andreas Kainz can confirm.

Comment 3 Grzesiek11 2021-11-23 18:51:29 UTC

If this is intentional, then the bug is that the icon picker isn't consistent with the change.

I honestly hope it's not. I'd get used to it, but it does look worse in my opinion.

Comment 4 andreas_k 2021-11-28 21:35:17 UTC

(In reply to Nate Graham from comment #1)
> - Dolphin (Breeze Light, correct):
> https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_165959.png
that's the correct behavior

> - Dolphin (Breeze Dark, incorrect):
> https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_165934.png
that's the correct behavior

> - Icon picker (Breeze Dark, correct):
> https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170121.png
that's a bug from the icon picker.

> - QuasselIRC (Breeze Light, correct):
> https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170028.png
> - QuasselIRC (Breeze Dark, incorrect; notice how most icons are almost
> invisible):
> https://grzesiek11.stary.pc.pl/files/images/Screenshot_20211119_170049.png

QuasselIRC has more than one issue. I think it's a mix between breeze-icons from QuasselIRC
and maybe some broken behavior about icon theming within QuasselIRC. 

Will check if I can help aththe QuasselIRC issues.

Comment 5 andreas_k 2021-11-28 22:00:06 UTC

> QuasselIRC has more than one issue.

it's a QuasselIRC issue not an breeze-icon issue. Sorry

Comment 6 Nate Graham 2021-11-29 17:28:12 UTC

Sounds like this is intentional, then. Please feel free to file a separate bug on the icon picker window mentioning that the emblem color *doesn't* change when it should. You would file that on frameworks-kiconthemes.

Thanks!