Bug 445726

Summary:	The option "Show in file manager" it's never translated
Product:	[Unmaintained] Plasma Vault	Reporter:	zocsfxljsgpmiuaanz
Component:	general	Assignee:	Ivan Čukić <ivan.cukic>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-vault/commit/1f7843decc8cb85315a5cc977fcfe6f0fbe4cdb5	Version Fixed/Implemented In:	5.23.4
Sentry Crash Report:

Description zocsfxljsgpmiuaanz 2021-11-19 00:12:23 UTC

SUMMARY
The option "Show in file manager" in the Plasma Vault applet it's always in English, not matter the language settings.

STEPS TO REPRODUCE
1. Have your system in a language different to English.
2. Have an open vault.
3. Click on the systray vault icon or add the Vaults applet to the desktop.

OBSERVED RESULT
All the options in the applet except "Show in File Manager" are in the system language.

EXPECTED RESULT
All the options in the applet are in the system language.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.85.0
Qt Version: 5.15.2

Comment 1 Bug Janitor Service 2021-11-19 13:10:48 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-vault/-/merge_requests/18

Comment 2 Nicolas Fella 2021-11-19 15:03:34 UTC

Git commit f8b184b992e1aca1b5c2487ad59498271bc68d08 by Nicolas Fella.
Committed on 19/11/2021 at 13:10.
Pushed by ngraham into branch 'master'.

Add missing translation domain

Like we do for other strings in this file

Otherwise the translation isn't loaded

FIXED-IN: 5.23.4

M  +1    -1    plasma/package/contents/ui/VaultItem.qml

https://invent.kde.org/plasma/plasma-vault/commit/f8b184b992e1aca1b5c2487ad59498271bc68d08

Comment 3 Nate Graham 2021-11-19 15:03:58 UTC

Git commit 1f7843decc8cb85315a5cc977fcfe6f0fbe4cdb5 by Nate Graham, on behalf of Nicolas Fella.
Committed on 19/11/2021 at 15:03.
Pushed by ngraham into branch 'Plasma/5.23'.

Add missing translation domain

Like we do for other strings in this file

Otherwise the translation isn't loaded

FIXED-IN: 5.23.4


(cherry picked from commit f8b184b992e1aca1b5c2487ad59498271bc68d08)

M  +1    -1    plasma/package/contents/ui/VaultItem.qml

https://invent.kde.org/plasma/plasma-vault/commit/1f7843decc8cb85315a5cc977fcfe6f0fbe4cdb5