| Summary: | When Milou search results are shown, first Esc key-press doesn't close effect; you need to do it twice | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Nate Graham <nate> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | alexander.lohnau |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/045c1337a9857b92a3bcf01f1f2b1784b4481892 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2021-11-18 17:56:15 UTC
No, it was an intentional behavior. Can we reconsider that? What's the reason for wanting Esc to clear the search field? I find it a bit annoying, as I had been using the Esc key to exit the whole effect. Now I need to think for a moment and press the Esc key 1 or 2 times based on whether search terms are visible. Searching seemed to me like a different mode, so Esc is used to leave the search mode and go back to the "normal" mode. (note that I'm a vim user, I like to think in terms of modes) If that's counterintuitive for most people, we can change that. I understand, but please understand that most people are not vim users and explicit modality is general discouraged in UI design unless it's unavoidable because all alternatives are worse. :) A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1690 Git commit 045c1337a9857b92a3bcf01f1f2b1784b4481892 by Vlad Zahorodnii. Committed on 19/11/2021 at 15:27. Pushed by vladz into branch 'master'. effects/overview: Make Esc key handling more intuitive when searching The person that added krunner search integration uses vim. It seemed intuitive to that person that the Escape key should quit the search mode instead of quitting the effect. But it seems like more intuitive thing is to actually stop the effect. M +2 -7 src/effects/overview/qml/ScreenView.qml https://invent.kde.org/plasma/kwin/commit/045c1337a9857b92a3bcf01f1f2b1784b4481892 |