Bug 445614

Summary:	"Toggle Filter Bar" button does not actually toggle
Product:	[Applications] dolphin	Reporter:	Thomas Rossi <trossi.dev>
Component:	bars: filter	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	isma.af, kfm-devel, me
Priority:	NOR
Version:	21.08.2
Target Milestone:	---
Platform:	Other
OS:	All
Latest Commit:	https://invent.kde.org/system/dolphin/-/commit/1939609e703b89d7e2c06514e373857ff2bc925b	Version Fixed In:	22.04
Sentry Crash Report:

Description Thomas Rossi 2021-11-16 20:42:35 UTC

SUMMARY
The "Toggle Filter Bar" on the toolbar does not toggle, it only makes the filter bar appear if it's not shown.


STEPS TO REPRODUCE AND OBSERVED RESULTS AGAINST EXPECTED RESULTS:
1. With the Filter bar non visible, click on the Filter button on the toolbar. The filter bar appears as expected
2. Click again on the button to close the bar, the bar stays opened.


EXAMPLE OF WORKING TOGGLE BUTTON:
This behavior works as expected with the search bar. Clicking on the "Toggle Seach bar" button will make the search bar appear if not showing, and disappear if showing.

Comment 1 ratijas 2022-02-04 18:58:24 UTC

*** Bug 449616 has been marked as a duplicate of this bug. ***

Comment 2 ratijas 2022-02-04 19:07:22 UTC

By the way, about the search bar: clicking on the icons toggles it, but pressing Ctrl+F shortcut doesn't toggle — it's the same as for filter bar.

Comment 3 Ismael Asensio 2022-02-04 22:02:25 UTC

A "Toggle Filter Bar" action is included since release 21.04 (commit https://invent.kde.org/system/dolphin/-/commit/60b9eaa4c1c4d3057934d2cefbbe986553090ab3), and works as expected, toggling the filter bar on and off.

There is also a "Show Filter Bar" action which just shows the filter bar. This is necessary to keep the keyboard workflow many users are used to. 

Unfortunately, the "Show" action was also mistakenly named as "Toggle", which causes the understandable confusion. This name has been fixed (commit https://invent.kde.org/system/dolphin/-/commit/1939609e703b89d7e2c06514e373857ff2bc925b) and will be released on 22.04.