Bug 445597

Summary:	Brush tips and brush size are not saved in bundle
Product:	[Applications] krita	Reporter:	Andreas Resch <andreas>
Component:	Resource Management	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	tamtamy.tymona
Priority:	NOR
Version:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Andreas Resch 2021-11-16 16:54:12 UTC

I've created a bundle of my brushes imported them back in, after deleting all the Krita folders from the appdata folders. Unfortunately the brush tips are not stored alongside the brushes and all brush sizes are set to 1px instead of the predefined size of the brush.


SOFTWARE/OS VERSIONS
Windows: 10 64-Bit
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Andreas Resch 2021-11-16 16:55:23 UTC

git hash is cd9295e

Comment 2 Tiar 2021-11-16 18:34:32 UTC

Were those brush tips from ABR file?

Comment 3 Andreas Resch 2021-11-16 18:40:48 UTC

Yes, they are.

I've already created a feature request over on the Krita Artist forum. It might be less of a bug than a rather undesirable way of importing the ABR file. Preferably the brush tips should be extracted from the ABR file and put into the brushes folder. That will result in a cleaner management of the brush tips and the bundle creator will be able to find those brush tips and properly include them in the bundle.

Here's the feature request in the forum ... https://krita-artists.org/t/extracting-brush-tips-from-abr-files-at-import/31932

I would appreciate it, if this could be implemented. After that I can create my brushes and back them up properly.

Comment 4 Tiar 2021-11-16 21:51:53 UTC

Since now we embed brush tips into presets, it might be a somewhat easy fix, but also might not be. In any case, it's not a regression since Krita 4 didn't support exporting bundles with ABR brush tips either.

*** This bug has been marked as a duplicate of bug 398685 ***

Comment 5 Andreas Resch 2021-11-17 08:15:30 UTC

I would strip the whole idea about using the ABR file as a bundle. There's no need to have an ABR file in the Krita folder. You already tag the imported brushes with the filename of the ABR file - that should be enough. Now I can add and delete brushes however I want. 

I've deleted a brush tip that came from an imported ABR file in Krita, and while it was deleted from the brush tip list, the ABR file wasn't updated. As you can see, this will lead to a lot of confusion down the road. When I delete a brush tip from Krita, it should be gone from the list as well as the Krita folder. When you convert the brush tips into your usual files, that shouldn't be an issue any more.

Comment 6 Andreas Resch 2021-11-17 08:44:44 UTC

Just as a confirmation. I've extracted the brush tip from the ABR file with abrmate and used that tip instead of the one from the ABR file. Now creating the bundle works and the extracted brush tip (as PNG) is included in the brushes directory. This supports the idea to get rid of the ABR file as brush tip container.