| Summary: | Krita crashes when selecting a brush | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Andreas Resch <andreas> |
| Component: | Resource Management | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eoinoneill1991, tamtamy.tymona |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/4b4f4d429fb7a7c835dc15fd5bb8c3f4339a69af | Version Fixed In: | |
| Attachments: | Crash Log | ||
Hi Andreas Resch, Regarding your bundle -- does it normally include the brush tips within the zip contents? The bug here could be related to how Krita loads that initial resource bundle, as trying to import a brush tip on it's own w/ a fresh version of Krita 5 works as expected on my end. Thanks, Eoin. (In reply to Eoin O'Neill from comment #1) > Hi Andreas Resch, > > Regarding your bundle -- does it normally include the brush tips within the > zip contents? The bug here could be related to how Krita loads that initial > resource bundle, as trying to import a brush tip on it's own w/ a fresh > version of Krita 5 works as expected on my end. > > Thanks, > Eoin. There is an issue with creating bundles and brush tips in ABR files that I've already filed. This might helps to solve this problem. However I've gone through the whole process again (export bundle, import bundle, add the ABR brush tips manually) and now the brush can be selected. So that bug might have some other reason as well. You would have to rely on the crash log to find out what it could be. I have no clue. Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. Git commit 103fb3f29ae2600d6bc1192833278ea56dc80c28 by Eoin O'Neill. Committed on 19/11/2021 at 03:04. Pushed by eoinoneill into branch 'master'. Fix nullptr crash associated with invalid access on `addResourceOrWarnIfNotLoaded` Since this method is supposed to warn the user, we shouldn't be risking a segfault on invalid function calls to null pointers! M +4 -3 libs/resources/KisRequiredResourcesOperators.cpp https://invent.kde.org/graphics/krita/commit/103fb3f29ae2600d6bc1192833278ea56dc80c28 Git commit 4b4f4d429fb7a7c835dc15fd5bb8c3f4339a69af by Eoin O'Neill. Committed on 19/11/2021 at 03:26. Pushed by eoinoneill into branch 'krita/5.0'. Fix nullptr crash associated with invalid access on `addResourceOrWarnIfNotLoaded` Since this method is supposed to warn the user, we shouldn't be risking a segfault on invalid function calls to null pointers! (cherry picked from commit 103fb3f29ae2600d6bc1192833278ea56dc80c28) M +4 -3 libs/resources/KisRequiredResourcesOperators.cpp https://invent.kde.org/graphics/krita/commit/4b4f4d429fb7a7c835dc15fd5bb8c3f4339a69af Andreas Resch, I've at least solved the crash here. If you are having difficulties importing resources, however, please let us know with another bug report. Thanks for taking the time to file a bug report!, Eoin. @Andreas the ABR issue is tracked here: bug 398685. I would mark this bug as "duplicate" but it got its own commit for the crash so I guess I'm going to leave it as "resolved" to show that there was something done. But you can subscribe to that other bug report to get updates. |
Created attachment 143619 [details] Crash Log After importing my backed up brush bundle (with obviously missing brush tips now - not sure how that happened), Krita crashes after selecting one of those brushes. I have imported some brush tips from my Photoshop export file like I did before, but I can't verify if the crash-causing brush uses one of those tips. It crashed immediately when I select it. Attached is the crash log. SOFTWARE/OS VERSIONS Windows: 10 64-Bit macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION