| Summary: | GStreamer with waylandsink in KDE Plasma Wayland session: Video doesn't update (works in GNOME or using Weston) | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Michael Weghorn <m.weghorn> |
| Component: | wayland-generic | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde, m.weghorn, nate, robert.mader |
| Priority: | NOR | ||
| Version: | 5.23.2 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwayland-server/commit/9aa436dc48f12e7ab4cb8fc9f9a06266b3ea1a1a | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screencast showing the differing behaviour between KWin in a Plasma Wayland session and in Weston
Screencast showing differing behaviour between KWin in a Plasma Wayland session and in Weston |
||
|
Description
Michael Weghorn
2021-11-11 16:24:42 UTC
Created attachment 143461 [details]
Screencast showing differing behaviour between KWin in a Plasma Wayland session and in Weston
This is an updated screencast, now actually running the same command in Weston as well, and showing that glimagesink works:
* first shows that waylandsink doesn't work as expected in "default" Plasma Wayland session
* then shows that waylandsink works in Weston
* then shows that glimagesink works in "default" Plasma Wayland session as well
(first version was using wrong command from bash history, sorry for that)
Does not happen when using QPainter compositing A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwayland-server/-/merge_requests/322 Git commit 9aa436dc48f12e7ab4cb8fc9f9a06266b3ea1a1a by Vlad Zahorodnii. Committed on 16/11/2021 at 07:24. Pushed by vladz into branch 'master'. Calculate correct surface-to-buffer matrix with only upscaled viewport Currently, if a wp_viewport upscales the surface but doesn't set the source rectangle, the surface-to-buffer matrix will be calculated incorrectly. If the source rect is not set, we need to calculate the source size based on the buffer size and compare it with the destination size. If the two are not the same, add a scale transform. M +11 -2 src/server/surface_interface.cpp https://invent.kde.org/plasma/kwayland-server/commit/9aa436dc48f12e7ab4cb8fc9f9a06266b3ea1a1a Thanks a lot for the quick fix! (In reply to Michael Weghorn from comment #0) > The actual/original use case where I came across this is LibreOffice, which > also uses "waylandsink" for video Playback in Impress presentations (added > in LibreOffice commit > https://git.libreoffice.org/core/+/ > 9d18bc40416b651340804f44ba5fae65f3bbbcfa%5E%21 for the gtk3 variant; I am > currently looking at this for the qt5/kf5/qt6 variant, since the > "qwidgetvideosink" which is currently used for the qt5/kf5 variants is no > longer under development and will possibly not be ported to Qt 6). When retesting this, it turned out that the sample program as well as the LibreOffice case works now, but only when using the gtk3 variant of LibreOffice, not when using the Qt one, which looks like another issue somewhere in the KDE/Qt stack. I've created follow-up bug 445631 with a new sample program that still has issues, but works in Weston. *** Bug 448470 has been marked as a duplicate of this bug. *** Just tested on 5.23.5 and unfortunately the fix is not yet backported. Would be very glad if it made it into 5.23.6 :) There isn't going to be a 5.23.6 (non-LTS Plasma versions only get five bugfix releases). So unless your distro's packagers backport it, we'll have to wit until Plasma 5.24 in a week or so. (In reply to Nate Graham from comment #8) > There isn't going to be a 5.23.6 (non-LTS Plasma versions only get five > bugfix releases). So unless your distro's packagers backport it, we'll have > to wit until Plasma 5.24 in a week or so. Thanks for pointing that out! |