Bug 445321

Summary:	Moving detached Git Commit tool view docks it to the last used docking position
Product:	[Applications] kdevelop	Reporter:	Igor Kushnir <igorkuo>
Component:	VCS: Git	Assignee:	kdevelop-bugs-null
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	https://invent.kde.org/kdevelop/kdevelop/-/commit/99596f83b5d18428a8a60ecba3ee08031c480bcc	Version Fixed/Implemented In:	6.2.250400
Sentry Crash Report:

Description Igor Kushnir 2021-11-11 09:45:42 UTC

SUMMARY
It is possible to detach and resize Git Commit tool view. But moving it usually (always?) docks it back.

STEPS TO REPRODUCE
1. Detach Git Commit tool view.
2. Grab with a mouse and move it.

OBSERVED RESULT
Git Commit tool view docks.

EXPECTED RESULT
Git Commit tool view moves into the new position and stays detached, unless it is moved close to a dock position. All other tool views I have tried work correctly, for example, Documents tool view.

SOFTWARE/OS VERSIONS
Manjaro GNU/Linux, Xfce
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2+kde+r237

Comment 1 Bug Janitor Service 2025-01-24 19:59:38 UTC

A possibly relevant merge request was started @ https://invent.kde.org/kdevelop/kdevelop/-/merge_requests/715

Comment 2 Igor Kushnir 2025-02-10 16:03:57 UTC

Git commit 99596f83b5d18428a8a60ecba3ee08031c480bcc by Igor Kushnir.
Committed on 10/02/2025 at 14:30.
Pushed by igorkushnir into branch 'master'.

sublime: don't remove the DockWidgetFloatable feature

IdealDockWidget() calls `setFeatures(QDockWidget::DockWidgetClosable |
    QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable)`.
IdealButtonBarWidget::addWidget() adds the DockWidgetVerticalTitleBar
feature to a dock widget in the bottom or the top dock widget area.
IdealController::dockLocationChanged() sets the same area-dependent dock
features except for DockWidgetFloatable. This bug was introduced in
fb1a0e4464a17eb6207257f23d6ae1fdb67def83, which added the
DockWidgetFloatable feature in IdealDockWidget() but a duplicate
DockWidgetMovable feature in IdealController::dockLocationChanged().
ea30a3e957830a7c861bac7475d5aba50ebc8716 then removed the duplicate
feature from dockLocationChanged().

IdealController::dockLocationChanged() already calls
IdealButtonBarWidget::addWidget(). So remove the
DockWidgetVerticalTitleBar feature if not needed in addWidget() instead
of repeating the always enabled feature set in dockLocationChanged().
FIXED-IN: 6.2.250400

M  +7    -2    kdevplatform/sublime/idealbuttonbarwidget.cpp
M  +0    -5    kdevplatform/sublime/idealcontroller.cpp

https://invent.kde.org/kdevelop/kdevelop/-/commit/99596f83b5d18428a8a60ecba3ee08031c480bcc