Bug 445282

Summary:	Overwriting a MyPaint preset creates a file with wrong extension (.myb instead of .kpp)
Product:	[Applications] krita	Reporter:	Dmitry Kazakov <dimula73>
Component:	Resource Management	Assignee:	amyspark <amy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	amy
Priority:	NOR	Keywords:	release_blocker
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/a4f84ca9a3070ff4fe5949da3e8028fe131f3b26	Version Fixed In:
Bug Depends on:	439817
Bug Blocks:

Description Dmitry Kazakov 2021-11-10 15:41:14 UTC

git sha1: e109a49e80eb47ffed80fafc9503e12a0af5d3df

STEPS TO REPRODUCE
1. Select "i) Wet Knife Plus (mypaint)" preset. Change its diameter to make it dirty
2. Press Overwrite

The file is saved as "i)_Wet_Knife_Plus_(mypaint).0001.myb", but it should be i)_Wet_Knife_Plus_(mypaint).0001.kpp, because it is a normal Krita preset now, not a JSON.

Comment 1 amyspark 2021-11-19 16:19:43 UTC

Will have a look at it, though I believe this is a consequence of bug 439817.

Comment 2 amyspark 2021-11-25 13:49:38 UTC

Git commit 14e8cd88b267d0c083cb7bee693d02f684d022d6 by L. E. Segovia.
Committed on 25/11/2021 at 13:47.
Pushed by lsegovia into branch 'krita/5.0'.

Fix naming of MyPaint brushes on versioned serialization

Before this commit, versioned .myb files would apply the .kpp suffix,
only to be overridden by the save preset dialog.
Related: bug 445281, bug 439817

M  +5    -6    libs/ui/dialogs/KisDlgSavePreset.cpp
M  +6    -4    plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp
M  +0    -7    plugins/paintops/mypaint/MyPaintPaintOpPreset.h

https://invent.kde.org/graphics/krita/commit/14e8cd88b267d0c083cb7bee693d02f684d022d6

Comment 3 amyspark 2021-11-25 13:53:12 UTC

Git commit a4f84ca9a3070ff4fe5949da3e8028fe131f3b26 by L. E. Segovia.
Committed on 25/11/2021 at 13:50.
Pushed by lsegovia into branch 'master'.

Fix naming of MyPaint brushes on versioned serialization

Before this commit, versioned .myb files would apply the .kpp suffix,
only to be overridden by the save preset dialog.
Related: bug 445281, bug 439817
(cherry picked from commit 14e8cd88b267d0c083cb7bee693d02f684d022d6)

M  +5    -6    libs/ui/dialogs/KisDlgSavePreset.cpp
M  +6    -4    plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp
M  +0    -7    plugins/paintops/mypaint/MyPaintPaintOpPreset.h

https://invent.kde.org/graphics/krita/commit/a4f84ca9a3070ff4fe5949da3e8028fe131f3b26