Summary: | Replace "this will remove some packages" dialog with a check for the transaction removing system-critical packages like plasma-workspace or kwin | ||
---|---|---|---|
Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
Status: | RESOLVED FIXED | ||
Severity: | grave | CC: | aleixpol, ws.kde |
Priority: | HI | Keywords: | usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/discover/commit/0cd9956adb0086c3587569ece14a1384c1ee23fd | Version Fixed In: | 5.24 |
Description
Nate Graham
2021-11-09 19:39:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/202 Git commit 0cd9956adb0086c3587569ece14a1384c1ee23fd by Aleix Pol. Committed on 19/11/2021 at 00:22. Pushed by ngraham into branch 'master'. pk: Create a mechanism to detect important packages getting removed Do not uninstall packages that are marked as compulsory for our current desktop. M +44 -1 discover/qml/DiscoverWindow.qml M +6 -0 libdiscover/Transaction/Transaction.h M +5 -0 libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp M +1 -0 libdiscover/backends/PackageKitBackend/AppPackageKitResource.h M +19 -9 libdiscover/backends/PackageKitBackend/PKTransaction.cpp M +5 -0 libdiscover/backends/PackageKitBackend/PackageKitResource.cpp M +5 -0 libdiscover/backends/PackageKitBackend/PackageKitResource.h M +28 -4 libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp M +6 -0 libdiscover/resources/AbstractBackendUpdater.h M +1 -0 libdiscover/resources/ResourcesUpdatesModel.cpp https://invent.kde.org/plasma/discover/commit/0cd9956adb0086c3587569ece14a1384c1ee23fd I've been instructed to discuss my requests under this bug report rather than filing multiples: I beg that important packages shouldn't even show up on the installed page, or at the very least not show a "Remove Button": A warning after clicking remove is a last ditched effort to block a stupid idea, it shouldn't be the first line of defense. If the user knows a application on the installed page is important and shouldn't be removed, he will not click the remove button to see if there's any warning. The mere presence of a "remove" button will creates a false sense of danger, it implies Discover is dumb and dangerous, that any application that has a remove button could potentially be a system application that shouldn't be removed. This is currently me right now. I also beg that there should be a separate page where "System" applications should reside, not under the main "Installed" page. Android does something similar. It should have Dolphin, Konsole and everything else that could be removed, but really shouldn't unless you know what you're doing. Add Discover to the list of applications that shouldn't even show up inside Discover. Letting the user nuke a tool with the tool itself is asking for disaster Those should in fact be filed as separate bug reports. They're not duplicates; they are separate (legitimate) issues. |