Summary: | Konsole crash when attempting to make new (and renamed) profile "default" | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Ty Wait <tywait13> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | a.samirh78 |
Priority: | NOR | Keywords: | drkonqi |
Version: | 21.08.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/utilities/konsole/commit/2d0fad18dc3d6fd8a45c50b8fd889889b473e0e2 | Version Fixed In: |
Description
Ty Wait
2021-11-08 18:45:45 UTC
I tested with your steps to reproduce, and I don't see this issue with the master branch; there has been various changes to the profile dialog(s), and so I assume it's been fixed in master. FWIW, when you edit the "built-in" profile, the code creates a new profile because the built-in one is immutable, it acts as a global fallback if you have no profiles at all. Ahmad - Thanks for your reply. I noticed there were several bugs involving Konsole's profile, so I'm amenable to your assessment. I'm running a KDE Neon system update now that includes a Konsole update. Maybe I should have applied that update earlier :-) I noticed the immutability of the "built-in" profile, and the rationale you present for such a profile being a global fallback makes a lot of sense. Thanks for the quick response!! -Ty On 11/8/21 2:39 PM, Ahmad Samir wrote: https://bugs.kde.org/show_bug.cgi?id=445173 Ahmad Samir <a.samirh78@gmail.com> [1] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| | a.samirh78@gmail.com [1] --- Comment #1 from Ahmad Samir <a.samirh78@gmail.com> [1] --- I tested with your steps to reproduce, and I don't see this issue with the master branch; there has been various changes to the profile dialog(s), and so I assume it's been fixed in master. FWIW, when you edit the "built-in" profile, the code creates a new profile because the built-in one is immutable, it acts as a global fallback if you have no profiles at all. 1. mailto:a.samirh78@gmail.com Git commit 2d0fad18dc3d6fd8a45c50b8fd889889b473e0e2 by Waqar Ahmed. Committed on 13/03/2023 at 18:31. Pushed by hindenburg into branch 'master'. Fix crash in ProfileSettings Fixes the following crash - Open Settings -> Manage Profiles... - Click on a non default profile and edit it - In "Edit Profile Dialog", check "Default" to make this profile default - Click Ok, Now we are back in "Manage Profiles" dialog. - See that "Set as Default" is still clickable, clicking it crashes konsole Related: bug 423136, bug 454986 M +6 -0 src/settings/ProfileSettings.cpp https://invent.kde.org/utilities/konsole/commit/2d0fad18dc3d6fd8a45c50b8fd889889b473e0e2 |