| Summary: | Fails to load images that contain a ` character. | ||
|---|---|---|---|
| Product: | [Unmaintained] kdeplasma-addons | Reporter: | northon_patrick3 |
| Component: | Media Frame | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.23.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/commit/5e16b5ab644748fbf38c2b7fa7113d8dc99bcc28 | Version Fixed/Implemented In: | 5.23.4 |
| Sentry Crash Report: | |||
|
Description
northon_patrick3
2021-11-06 12:25:36 UTC
More info:
```
QUrl url1{"/tmp/test`test.txt"};
std::cout << url1.toString(QUrl::PreferLocalFile).toStdString() << '\n';
QUrl url2{"file:///tmp/test`test.txt"};
std::cout << url2.toString(QUrl::PreferLocalFile).toStdString() << '\n';
```
will output:
```
/tmp/test%60test.txt
/tmp/test`test.txt
```
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/95 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/95 Git commit 181cc49c4d44a4ac926051ebf9a53d0a8fc6b253 by Patrick Northon. Committed on 08/11/2021 at 16:34. Pushed by ngraham into branch 'master'. [mediaframe] Make files added from paths into URLs. This make it consistent with individual files added and fix a problem where the url isn't converted to a path properly in some conditions when the url doesn't contain the schema (file://). M +1 -1 applets/mediaframe/plugin/mediaframe.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/181cc49c4d44a4ac926051ebf9a53d0a8fc6b253 Git commit 5e16b5ab644748fbf38c2b7fa7113d8dc99bcc28 by Nate Graham, on behalf of Patrick Northon. Committed on 10/11/2021 at 21:23. Pushed by ngraham into branch 'Plasma/5.23'. [mediaframe] Make files added from paths into URLs. This make it consistent with individual files added and fix a problem where the url isn't converted to a path properly in some conditions when the url doesn't contain the schema (file://). (cherry picked from commit 181cc49c4d44a4ac926051ebf9a53d0a8fc6b253) M +1 -1 applets/mediaframe/plugin/mediaframe.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/5e16b5ab644748fbf38c2b7fa7113d8dc99bcc28 |