Bug 444964

Summary: clazy couldnt compile on llvm13 systems
Product: [Developer tools] clazy Reporter: Ömer Fadıl USTA <omerusta>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: major CC: smartins
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Ömer Fadıl USTA 2021-11-04 17:21:29 UTC 
contains_lower doesnt exist llvm13

With llvm they renamed StringRef's method names and removed old ones [1] and [2]

https://invent.kde.org/sdk/clazy/-/blob/master/src/checks/manuallevel/unexpected-flag-enumerator-value.cpp#L67

cause build break on llvm13 systems.

contains_lower -> (probably to) contains_insensitive

It will be nice to add a control for which version of llvm is using while compiling and use that version's code for contains_.... part

[1] : https://reviews.llvm.org/D104820

[2] : https://github.com/llvm/llvm-project/commit/2e4a2b8430aca6f7aef8100a5ff81ca0328d03f9
Comment 1 Ömer Fadıl USTA 2021-11-04 17:23:55 UTC 
[Same bug entry crossreported to  gitlab ( invent.kde.org) 's issue board  [1] ]
[1] : https://invent.kde.org/sdk/clazy/-/issues/4
Comment 2 Sergio Martins 2021-11-05 16:32:29 UTC 
it now uses contains_insensitive if llvm13