Summary: | ksgrd_network_helper aborted when starting plasma-systemmonitor 5.23.2 | ||
---|---|---|---|
Product: | [Applications] plasma-systemmonitor | Reporter: | Matt Fagnani <matt.fagnani> |
Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahiemstra, nate, plasma-bugs |
Priority: | NOR | ||
Version: | 5.23.2 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/libksysguard/commit/1344cf98af560570fc661b175643b7a90cb7ac52 | Version Fixed In: | 5.23.3 |
Description
Matt Fagnani
2021-11-04 06:30:43 UTC
https://invent.kde.org/plasma/libksysguard/-/merge_requests/193 takes care of the abort. That said, the abort shouldn't really happen in the first place and only seems to happen because of a packaging bug. `ksgrd_network_helper` needs `CAP_NET_RAW` to run, as it needs to capture all the packets going over network devices. It seems Fedora's package doesn't set that. That should be reported to Fedora somewhere. Git commit 457bac238af23539134525ea4cfb37cca870e9ca by Arjen Hiemstra, on behalf of Loïc Yhuel. Committed on 04/11/2021 at 10:41. Pushed by ahiemstra into branch 'master'. Fix ksgrd_network_helper crash on exit afer a failure On an early return in main, the ConnectionMapping thread was destroyed without being properly joined, leading to an abort. So ConnectionMapping::stop has been changed into a destructor. m_running is also now set from the main thread, to ensure any early destruction while the thread is starting stops it properly. M +10 -10 processcore/plugins/network/helper/ConnectionMapping.cpp M +1 -2 processcore/plugins/network/helper/ConnectionMapping.h M +0 -1 processcore/plugins/network/helper/main.cpp https://invent.kde.org/plasma/libksysguard/commit/457bac238af23539134525ea4cfb37cca870e9ca Git commit 1344cf98af560570fc661b175643b7a90cb7ac52 by Arjen Hiemstra, on behalf of Loïc Yhuel. Committed on 04/11/2021 at 10:43. Pushed by ahiemstra into branch 'Plasma/5.23'. Fix ksgrd_network_helper crash on exit afer a failure On an early return in main, the ConnectionMapping thread was destroyed without being properly joined, leading to an abort. So ConnectionMapping::stop has been changed into a destructor. m_running is also now set from the main thread, to ensure any early destruction while the thread is starting stops it properly. (cherry picked from commit 457bac238af23539134525ea4cfb37cca870e9ca) M +10 -10 processcore/plugins/network/helper/ConnectionMapping.cpp M +1 -2 processcore/plugins/network/helper/ConnectionMapping.h M +0 -1 processcore/plugins/network/helper/main.cpp https://invent.kde.org/plasma/libksysguard/commit/1344cf98af560570fc661b175643b7a90cb7ac52 (In reply to Arjen Hiemstra from comment #1) > https://invent.kde.org/plasma/libksysguard/-/merge_requests/193 takes care > of the abort. That said, the abort shouldn't really happen in the first > place and only seems to happen because of a packaging bug. > `ksgrd_network_helper` needs `CAP_NET_RAW` to run, as it needs to capture > all the packets going over network devices. It seems Fedora's package > doesn't set that. That should be reported to Fedora somewhere. Arjen, I've quoted your comment in one on my report for Fedora at https://bugzilla.redhat.com/show_bug.cgi?id=2020138#c1 Thanks. |