| Summary: | "Critical section not initialized" warning in lcms | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | halla |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| URL: | https://github.com/mm2/Little-CMS/issues/289 | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/a4bd7fd0e7175a58c63b88cdcfc93607c0d18f52 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | warning and backtrace | ||
Looks like it's a bug in lcms, not in Krita. From lcms's code, the critical section is to be initialized in `cmsCreateContext` [1]. Looking at Krita's code however, this function is never called. If it is completely expected to not call this function, then it would seem that yes, it is an upstream issue. Opened https://github.com/mm2/Little-CMS/issues/289 [1]: https://github.com/mm2/Little-CMS/blob/0b845e907e63129110e2ce5ee2e4476e7b6efd08/src/cmsplugin.c#L805 --- (Extra info:) There is also a note in `lcms2_internal.h` [2]: > 1) [...] > > 2) In cases where we want to work on pre-Windows XP, we > can use an even more horrible hack described below. > > So why wouldn't we always use 2)? Because not calling > the init function for a critical section means it fails > testing with ApplicationVerifier (and presumably similar > tools). But this is evidently not applicable here, because: - `CMS_RELY_ON_WINDOWS_STATIC_MUTEX_INIT` is unset, which means this hack isn't used. - "Critical section debug info address" is 0 instead of (void *)-1, which validates the last point. [2]: https://github.com/mm2/Little-CMS/blob/0b845e907e63129110e2ce5ee2e4476e7b6efd08/src/lcms2_internal.h#L211-L256 Eh, now I'm really confused :-) Upstream made a fix for this. I'll test it next time we update the deps I guess. Verified fixed by lcms update https://invent.kde.org/graphics/krita/-/commit/a4bd7fd0e7175a58c63b88cdcfc93607c0d18f52 |
Created attachment 143166 [details] warning and backtrace Application Verifier gives this warning on starting Krita. I'm not sure how big of an issue this is. (Nightly 5214230c5a)