| Summary: | Abnormal undo function when using the Transform tool | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | thetwo <thetwo222> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ahab.greybeard, intuos5, tamtamy.tymona |
| Priority: | NOR | ||
| Version: | 5.0.0-beta2 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/f5657e1c97564dfe811b66e8d8a462454a620bba | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
thetwo
2021-11-01 19:27:09 UTC
Do I assume correctly it doesn't happen this way in Krita 4.x? (In reply to Tiar from comment #1) > Do I assume correctly it doesn't happen this way in Krita 4.x? I don‘t know...... But it would be better if it was synchronized with the Bezier curve tool, which also does undo operations properly while it is running. In contrast, the undo of the Transform tool is redundant and inconvenient It's the same behaviour as in 4.4.8. When the Transform tool bounding box appears, you haven't actually made any changes to the image. I select a different tool if I want to back out and get rid of the Transform bounding box. If you do a rotation and don't finalise it, then Ctrl+Z will undo that rotation, leaving the bounding box as it orginally was. You can do multiple sequential transform actions (without finalising) and use Ctrl+Z to undo them individualy back in sequence. Then you need two Ctrl+Z presses to remove the bounding box. I think this is useful to let you know, by the lack of change on the first press, that you've reached the end of the undo sequence. (In reply to Ahab Greybeard from comment #3) > It's the same behaviour as in 4.4.8. > > When the Transform tool bounding box appears, you haven't actually made any > changes to the image. > I select a different tool if I want to back out and get rid of the Transform > bounding box. > > If you do a rotation and don't finalise it, then Ctrl+Z will undo that > rotation, leaving the bounding box as it orginally was. > You can do multiple sequential transform actions (without finalising) and > use Ctrl+Z to undo them individualy back in sequence. > Then you need two Ctrl+Z presses to remove the bounding box. I think this is > useful to let you know, by the lack of change on the first press, that > you've reached the end of the undo sequence. Is that so? I found that if I perform transformation steps, I am not able to undo them individually by using Ctrl+Z. I can exit the tool and undo the transformation as a whole, which basically reverts back to the state before I activated the transform tool. This is in Beta 2. STEPS TO REPRODUCE 1. Select a portion of an image with the marquee selection tool (rectangular selection) 2. Invoke the transform tool and scale/ rotate the selection 3. Hit ctrl+z a bunch of times As you can see, it does not actually undo any of what I did with the transform tool active. This video illustrates it happening (10.6MB .mkv download): https://www.dropbox.com/s/v6m3xcv18kvmuro/Undo-Transform-Sequence.mkv?dl=1 After the four individual (and not finalised) transform operations, six Ctrl+Z presses were done. The fifth one had no efect, the sixth one removed the transform bounding box. Git commit b7364f3b14ad4d798178f6f922d2d70309b6ece0 by Dmitry Kazakov. Committed on 23/10/2023 at 17:08. Pushed by dkazakov into branch 'master'. Fix extra in-stroke undo step when using Transform and Move tools M +12 -6 libs/ui/tool/KisToolChangesTracker.cpp M +4 -1 libs/ui/tool/KisToolChangesTracker.h M +5 -3 plugins/tools/basictools/kis_tool_move.cc M +6 -5 plugins/tools/tool_transform2/kis_tool_transform.cc https://invent.kde.org/graphics/krita/-/commit/b7364f3b14ad4d798178f6f922d2d70309b6ece0 Git commit f5657e1c97564dfe811b66e8d8a462454a620bba by Dmitry Kazakov. Committed on 28/02/2024 at 12:42. Pushed by dkazakov into branch 'kazakov/for-5.2'. Fix extra in-stroke undo step when using Transform and Move tools M +12 -6 libs/ui/tool/KisToolChangesTracker.cpp M +4 -1 libs/ui/tool/KisToolChangesTracker.h M +5 -3 plugins/tools/basictools/kis_tool_move.cc M +6 -5 plugins/tools/tool_transform2/kis_tool_transform.cc https://invent.kde.org/graphics/krita/-/commit/f5657e1c97564dfe811b66e8d8a462454a620bba |