| Summary: | KisAnimTimelineFramesView invalid memory access on closing Krita | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Alvin Wong <alvin> |
| Component: | Animation | Assignee: | Eoin O'Neill <eoinoneill1991> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | amy, emmetoneill.pdx, eoinoneill1991 |
| Priority: | NOR | Keywords: | release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/82bc4dbbc52c14fab614b727b468c56618288103 | Version Fixed In: | |
| Attachments: | backtrace | ||
I'll take a look at this tomorrow. Git commit 5214230c5a9a4047b875292a85439074c8e20cc3 by Eoin O'Neill. Committed on 02/11/2021 at 21:52. Pushed by eoinoneill into branch 'master'. Fixed crash on document close caused by invalid lambda lifetime for signal. There still seem to be other places where Krita is crashing on close, but at least this lifetime issue has been fixed. M +1 -1 plugins/dockers/animation/KisAnimTimelineFramesView.cpp https://invent.kde.org/graphics/krita/commit/5214230c5a9a4047b875292a85439074c8e20cc3 Git commit 82bc4dbbc52c14fab614b727b468c56618288103 by Eoin O'Neill. Committed on 03/11/2021 at 22:02. Pushed by eoinoneill into branch 'krita/5.0'. Fixed crash on document close caused by invalid lambda lifetime for signal. There still seem to be other places where Krita is crashing on close, but at least this lifetime issue has been fixed. (cherry picked from commit 5214230c5a9a4047b875292a85439074c8e20cc3) M +1 -1 plugins/dockers/animation/KisAnimTimelineFramesView.cpp https://invent.kde.org/graphics/krita/commit/82bc4dbbc52c14fab614b727b468c56618288103 |
Created attachment 143006 [details] backtrace Caught this with Application Verifier (had to also use a bit of hack to bypass another problem). Steps performed: 1. Open file A 2. Open file B 3. Switch to file A 4. Make a change 5. Close Krita and choose "no" when asked to save changes Without Application Verifier it causes an apparently random unrelated crash. Nightly 4ff1b5a2b1, also happens on 5.0 branch