Bug 444322

Summary:	'No media playing' text is not centered
Product:	[Plasma] plasmashell	Reporter:	Patrick Silva <bugseforuns>
Component:	Media Player widget	Assignee:	Patrick Silva <bugseforuns>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs-null, qydwhotmail
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/ac565420444f67f0efb7c9f853d0f92689864311	Version Fixed/Implemented In:	5.24
Sentry Crash Report:
Attachments:	screenshot no media playing playing video

Description Patrick Silva 2021-10-24 13:10:33 UTC

SUMMARY
Please see the attached screenshot.

EXPECTED RESULT
horizontally/vertically centered 'No media playing' text

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.88.0
Qt Version: 5.15.3
Graphics Platform: Wayland

Comment 1 Patrick Silva 2021-10-24 13:11:27 UTC

Created attachment 142815 [details]
screenshot

Comment 2 Nate Graham 2021-10-25 21:11:12 UTC

Git commit 12e307399c5da49db97943f1c78eb0223d832a84 by Nate Graham.
Committed on 25/10/2021 at 21:10.
Pushed by ngraham into branch 'master'.

applets/mediacontroller: Use a real placeholder message component

Right now we are bodging the track label into being this, but it looks
bad and doesn't use the standardized component, which it should. So now
it does.
FIXED-IN: 5.24

M  +9    -1    applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/12e307399c5da49db97943f1c78eb0223d832a84

Comment 3 Patrick Silva 2021-11-25 09:45:24 UTC

Created attachment 143931 [details]
no media playing

Not fixed yet. Also there is unnecessary space between the app icon and file name/folder during playback. Please see the attached screenshots.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.89.0
Qt Version: 5.15.3
Graphics Platform: Wayland

Comment 4 Patrick Silva 2021-11-25 09:47:01 UTC

Created attachment 143932 [details]
playing video

Comment 5 Bug Janitor Service 2021-11-25 17:14:01 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1219

Comment 6 Fushan Wen 2021-11-25 17:29:39 UTC

About the icon size, do you have another bugzillla ID?

Comment 7 Fushan Wen 2021-12-01 00:14:10 UTC

Git commit ac565420444f67f0efb7c9f853d0f92689864311 by Fushan Wen.
Committed on 30/11/2021 at 23:57.
Pushed by fusionfuture into branch 'master'.

applets/mediacontroller: Move PlaceholderMessage to albumRow and load it on demand

1. placeholderMessage and fallbackIconItem are put in the same Loader and
   loaded on demand, and they share the same icon property.
2. When getting "Desktop Icon Name", check if `mpris2Source.currentData` is
   available first.
3. Hide the details column when no track is available.
Related: bug 446095
FIXED-IN: 5.24

M  +32   -19   applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ac565420444f67f0efb7c9f853d0f92689864311

Comment 8 Patrick Silva 2022-04-09 14:30:16 UTC

(In reply to Fushan Wen from comment #6)
> About the icon size, do you have another bugzillla ID?

please see bug 452436