| Summary: | New Numbered Game Limited To 9 (Nine) Numbers | ||
|---|---|---|---|
| Product: | [Applications] kmahjongg | Reporter: | Shadders <richard.shadbolt> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, kde-games-bugs |
| Priority: | NOR | ||
| Version: | 0.9.21043 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/games/kmahjongg/commit/21f71613273f38454dc9644883f9e4b112af8d67 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | kmahjongg_10digit_game | ||
|
Description
Shadders
2021-10-21 12:12:07 UTC
Do you remember which version you had before that allowed you to enter more numbers? Hi, Last version that i had installed as per distro (7th November 2020 installed) is : kmahjongg-19.12.2-1.fc32.x86_64 It seems fedora packaged kmahjongg in F32 for F33 build. Last time i repeated a game was May 2021. Update to version as per bug report was 16th October 2021, upgrade from F33 to F34. Regards, Shadders. I just checked that version and the maximum number you can enter is 2147483647, same as with the current version. Which number are you expecting to be able to enter? Hi, In May 2021 i replayed the following games : 1086501009, 1813846301, 1805500308 All three are 10 digit numbers. The version as per bug report only allow 9 numbers to be entered. Game i am attempting to replay is 4162709682. Regards, Shadders. (In reply to Shadders from comment #4) > Hi, > In May 2021 i replayed the following games : > 1086501009, 1813846301, 1805500308 > > All three are 10 digit numbers. The version as per bug report only allow 9 > numbers to be entered. Are you sure about that? I can enter 1086501009 just fine, as said the max number is 2147483647 > Game i am attempting to replay is 4162709682. I'm sorry but I can't find any version in which such game number was allowed. Anyhow game numbers changed since 20.12 and the numbers don't mean exactly what they meant, so playing the same number won't get you the same game as pre-20.12 verisons. Hi, Yes, i just click new game and the number is : 4097895855 A few more new game clicks and 3165032516, 3297680504. So, yesterday i noted the game 4162709682. This is the number i cannot replay on kmahjongg 0.9.21043 (as per Help -> About Mahjongg). Regards, Shadders. Created attachment 142747 [details]
kmahjongg_10digit_game
Example of 10 digit game Mahjongg
A possibly relevant merge request was started @ https://invent.kde.org/games/kmahjongg/-/merge_requests/3 Ah, i see the problem now, the new random code is generating too big numbers. Git commit 21f71613273f38454dc9644883f9e4b112af8d67 by Albert Astals Cid. Committed on 22/10/2021 at 19:48. Pushed by aacid into branch 'release/21.08'. Don't generate random game numbers bigger than INT_MAX Since we don't allow users to enter a numbered number bigger than it either M +1 -1 src/gameview.cpp https://invent.kde.org/games/kmahjongg/commit/21f71613273f38454dc9644883f9e4b112af8d67 |