Bug 444167

Summary: Not asking for openvpn private key password
Product: [Plasma] plasmashell Reporter: Markus Pister <info>
Component: Networks widgetAssignee: Jan Grulich <jgrulich>
Status: VERIFIED DUPLICATE    
Severity: normal CC: jgrulich
Priority: NOR    
Version First Reported In: master   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot of password dialog only asking for one password
Expected password dialog as shown in 5.22.5 version

Description Markus Pister 2021-10-21 05:50:27 UTC 
SUMMARY
When activating an openvpn connection (type Password with certificates (TLS)), the password field for the openvpn private key is missing although both passwords (private key and password) are configured to be prompted every time in the connection settings.

Issue started to appear in plasma-nm-5.23.1-1-x86_64.pkg.tar.zst on my Arch installation. The previous package (plasma-nm-5.22.5-1-x86_64.pkg.tar.zst) works fine.


STEPS TO REPRODUCE
1. Create an openvpn connection
1.1 Enter valid gateway server
1.2 type: "Password with certificates (TLS)"
1.3 Configured CA certificate, User certificate and private key files
1.4 Configure "Private Key Password" to be prompted every time
1.5 Configure "Password" to be prompted every time
1.6 Leave "Username" empty

2. Activate created connection


OBSERVED RESULT
A dialog appears that asks for "Provide the secrets for the VPN connection '...'" with a single password field.


EXPECTED RESULT
A dialog appears that asks for both the password and the private key password.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.23.1
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
The openvpn connection works fine when storing the passwords in the settings dialog. So, the issue is only about not prompting for the private key password.
Comment 1 Markus Pister 2021-11-09 14:32:48 UTC 
I could deduce the commit which introduced the reported behavior change:

3213592ca5180a3ac61b72a2d0e473b258ae9115 is the first bad commit
commit 3213592ca5180a3ac61b72a2d0e473b258ae9115
Author: Jan Grulich <jgrulich@redhat.com>
Date:   Wed Jul 21 11:18:59 2021 +0200

    OpenVPN: support hints and simplify logic in the auth dialog

 vpn/openvpn/openvpnauth.cpp | 112 ++++++++++++++++++++++++++------------------
 vpn/openvpn/openvpnauth.h   |   2 +
 2 files changed, 68 insertions(+), 46 deletions(-)


Current master (HEAD: b03c7e8f) still only asks for one password.
Comment 2 Markus Pister 2021-11-09 14:33:40 UTC 
Created attachment 143372 [details]
Screenshot of password dialog only asking for one password
Comment 3 Markus Pister 2021-11-09 14:34:12 UTC 
Created attachment 143373 [details]
Expected password dialog as shown in 5.22.5 version
Comment 4 Jan Grulich 2021-11-10 07:02:20 UTC 
Hi, this should be (hopefully) fixed in Plasma 5.23.3 with https://invent.kde.org/plasma/plasma-nm/-/commit/48fad4ac77520d673414ef957e6dedc4d151eb73. Can you verify?
Comment 5 Jan Grulich 2021-11-10 07:02:50 UTC 

*** This bug has been marked as a duplicate of bug 444882 ***
Comment 6 Markus Pister 2021-11-10 08:30:07 UTC 
(In reply to Jan Grulich from comment #4)
> Hi, this should be (hopefully) fixed in Plasma 5.23.3 with
> https://invent.kde.org/plasma/plasma-nm/-/commit/
> 48fad4ac77520d673414ef957e6dedc4d151eb73. Can you verify?

Yes, I just tested the newest Arch package build containing 5.23.3 from yesterday. This fixes the reported issue.

Thanks.
Comment 7 Ben Cooksley 2024-12-23 18:26:03 UTC 
Bulk transfer as requested in T17796