Bug 444157

Summary: rotating scanned pages fails on pdf export
Product: [Applications] Skanpage Reporter: dominik.zinke
Component: generalAssignee: Alexander Stippich <a.stippich>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: sample scan with error on page 3

Description dominik.zinke 2021-10-20 21:39:54 UTC
Created attachment 142699 [details]
sample scan with error on page 3

SUMMARY
rotating scanned pages fails on pdf export

STEPS TO REPRODUCE
1. scan document
2. rotate page
3. save to pdf

OBSERVED RESULT
the rotated page is only visible partially on pdf

EXPECTED RESULT
rotaed page to be fully visible in correct orientation

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Alexander Stippich 2021-10-23 11:03:42 UTC
Git commit 4850842a074049a4b89b52fd2b669910114a9200 by Alexander Stippich.
Committed on 23/10/2021 at 11:02.
Pushed by astippich into branch 'master'.

fix PDF saving with rotation

extend test case

M  +36   -0    autotests/documentSaverTest.cpp
M  +9    -6    src/DocumentSaver.cpp

https://invent.kde.org/utilities/skanpage/commit/4850842a074049a4b89b52fd2b669910114a9200
Comment 2 Alexander Stippich 2021-10-23 11:04:45 UTC
Thanks for the report!
There were indeed some issues with rotation and PDF saving.
Could you please retry with git master?
Comment 3 Alexander Stippich 2021-10-30 08:31:26 UTC
Closing as this has supposedly been fixed. Please reopen if the issue persists
Comment 4 Alexander Stippich 2021-11-01 09:55:48 UTC
Git commit d18fdf8d5ded80a02587e41b776e8466d974a021 by Alexander Stippich.
Committed on 30/10/2021 at 08:44.
Pushed by astippich into branch '1.0'.

fix PDF saving with rotation

extend test case

M  +36   -0    autotests/documentSaverTest.cpp
M  +9    -6    src/DocumentSaver.cpp

https://invent.kde.org/utilities/skanpage/commit/d18fdf8d5ded80a02587e41b776e8466d974a021
Comment 5 dominik.zinke 2021-11-05 17:50:56 UTC
Tested Skanpage 1.0.99. Can confirm the rotate function and pdf export is working correctly.
Comment 6 dominik.zinke 2021-11-05 18:01:01 UTC
Version 1.0.0 from AUR also working