Summary: | Creating new workspace from the window menu gives error - git 1913d80 | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Raghavendra kamath <raghu> |
Component: | Resource Management | Assignee: | Tiar <tamtamy.tymona> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | tamtamy.tymona, tomtomtomreportingin |
Priority: | NOR | Keywords: | regression |
Version: | nightly build (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/19f51d40557304f86916848393edfdfa94211df3 | Version Fixed In: |
Description
Raghavendra kamath
2021-10-20 14:07:58 UTC
Yep, noticed this a couple days ago and haven't gotten around to reporting it. In Krita 4, creating a new workspace with the described method would open a new window for naming the workspace. If that was intentionally removed, the problem is that Krita 5 doesn't properly handle resources created with characterless names (or names with only spaces/underscores), though perhaps that should be reported separately. In Krita 4, a fixed-length string of random characters would be generated if a resource was created without a name. By the way, this issue does NOT occur in 5.0 beta 1, as the described method will create a new window for entering the name in that version. The issue starts occurring as of 5.0 beta 2. Git commit 19c8ee284bc1d5497fd29da746e8347cff144cbc by Agata Cacko. Committed on 22/10/2021 at 12:56. Pushed by tymond into branch 'master'. Fix broken adding a workspace from the main menu Before this commit, there was no way to define a name for the new workspace in Window -> Workspaces -> New Workspace..., so Krita would always try to call it "" (empty string). This of course always failed. This commit fixes that by readding previously removed (by mistake) QInputDialog asking for the name of the resource. M +6 -2 libs/ui/KisMainWindow.cpp https://invent.kde.org/graphics/krita/commit/19c8ee284bc1d5497fd29da746e8347cff144cbc Git commit 19f51d40557304f86916848393edfdfa94211df3 by Agata Cacko. Committed on 26/10/2021 at 18:14. Pushed by tymond into branch 'krita/5.0'. Fix broken adding a workspace from the main menu Before this commit, there was no way to define a name for the new workspace in Window -> Workspaces -> New Workspace..., so Krita would always try to call it "" (empty string). This of course always failed. This commit fixes that by readding previously removed (by mistake) QInputDialog asking for the name of the resource. M +6 -2 libs/ui/KisMainWindow.cpp https://invent.kde.org/graphics/krita/commit/19f51d40557304f86916848393edfdfa94211df3 |