Bug 443732

Summary: [KCommandBar] Commands without name
Product: [Frameworks and Libraries] frameworks-kwidgetsaddons Reporter: popov895 <popov895>
Component: generalAssignee: Christoph Feck <cfeck>
Status: RESOLVED FIXED    
Severity: normal CC: kdelibs-bugs, nate, popov895
Priority: NOR    
Version: 5.86.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Commands without name

Description popov895 2021-10-14 16:39:19 UTC
Created attachment 142440 [details]
Commands without name

SUMMARY

Some applications (e.g. Dolphin) have commands without name. It would be great if the KCommandBar didn't display such commands, since it's not clear what they do anyway.

SOFTWARE/OS VERSIONS

Operating System: openSUSE Tumbleweed 20211011
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Bug Janitor Service 2021-10-16 08:53:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/81
Comment 2 popov895 2021-10-16 10:23:57 UTC
Git commit 70238c3badb0a5dfcbee7244888420b13df9a2c2 by Eugene Popov.
Committed on 16/10/2021 at 10:02.
Pushed by waqar into branch 'master'.

[KCommandBar] Skip actions with empty text

Don't add action with empty text, since it's not clear what they do anyway.

M  +6    -0    src/kcommandbarmodel_p.cpp

https://invent.kde.org/frameworks/kconfigwidgets/commit/70238c3badb0a5dfcbee7244888420b13df9a2c2