| Summary: | Keyboard repeat speed is ignored under wayland | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Till Schäfer <till2.schaefer> |
| Component: | kcm_keyboard | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bob, bugseforuns, butirsky, mystica, nate, rushpl |
| Priority: | NOR | Keywords: | wayland |
| Version: | 5.23.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=410626 https://bugs.kde.org/show_bug.cgi?id=444589 https://bugs.kde.org/show_bug.cgi?id=450319 |
||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/ac081cad79930a419d413858ca2c3400d571d569 | Version Fixed In: | 5.23.3 |
| Sentry Crash Report: | |||
|
Description
Till Schäfer
2021-10-14 15:24:06 UTC
Its also always the same speed not matter if it is qt or gtk application On my system repeat rate changes slightly compared to X11, see bug 410626 comment 7 . Operating System: Arch Linux KDE Plasma Version: 5.23.0 KDE Frameworks Version: 5.87.0 Qt Version: 5.15.2 Graphics Platform: Wayland Can confirm, the change seems to be ignored or is so small as to be indistinguishable for me. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1553 Git commit 4395caa2568e8200f719007484609bc6ee191351 by Andrey Butirsky. Committed on 25/10/2021 at 14:04. Pushed by butirsky into branch 'master'. [wayland] fix ignored keyboard RepeatRate X11 can take float RepeatRate, Wayland - int only so the setting is to be rounded. Should be indistinguishable on usual rates. M +1 -1 src/input.cpp https://invent.kde.org/plasma/kwin/commit/4395caa2568e8200f719007484609bc6ee191351 Git commit 1dc40064e3abb614c960dab494d7dd0796a48795 by Andrey Butirsky. Committed on 25/10/2021 at 14:06. Pushed by butirsky into branch 'Plasma/5.23'. [wayland] fix ignored keyboard RepeatRate X11 can take float RepeatRate, Wayland - int only so the setting is to be rounded. Should be indistinguishable on usual rates. (cherry picked from commit 4395caa2568e8200f719007484609bc6ee191351) M +1 -1 src/input.cpp https://invent.kde.org/plasma/kwin/commit/1dc40064e3abb614c960dab494d7dd0796a48795 I have tested it with plasma 5.23.2 and there seem to be some side effects of the fix. 1. While, the interval [1,50] seems to work as expected, the interval [50,100] seems to be capped at 50 repeats in the test area. However, in other places like kate and konsole, 100 repeats are possible. 2. The fractional repeat rates below 1 seem to be "rounded" to 0, which disables the repeating behavior at all. Which seems a bit unexpected since there exist the extra option of disabling repeat above. For the second case it seem reasonable to round using ceil instead of floor. Point 2 (capping at 50 repeats) also affects kirigami apps such as neochat and all plasma input areas. Thus, this may not be an issue related to the original bug here. (In reply to Till Schäfer from comment #8) > Point 2 (capping at 50 repeats) also affects kirigami apps such as neochat > and all plasma input areas. Thus, this may not be an issue related to the > original bug here. Nevertheless, this seems to be wayland only. On X11 repeat rates above 50 work in the test area, plasma applets and other kirigami apps. (In reply to Till Schäfer from comment #9) > Nevertheless, this seems to be wayland only. On X11 repeat rates above 50 > work in the test area, plasma applets and other kirigami apps. Would you open a separate issue about this? (In reply to Till Schäfer from comment #7) > 2. The fractional repeat rates below 1 seem to be "rounded" to 0, which > disables the repeating behavior at all. Which seems a bit unexpected since > there exist the extra option of disabling repeat above. > > For the second case it seem reasonable to round using ceil instead of floor. There will be "0" position disabling the rate, anyway, so maybe not too unexpected? I'm not against it, just asking. (In reply to Andrey from comment #10) > (In reply to Till Schäfer from comment #9) > > Nevertheless, this seems to be wayland only. On X11 repeat rates above 50 > > work in the test area, plasma applets and other kirigami apps. > Would you open a separate issue about this? I have opened Bug 444589 (In reply to Andrey from comment #11) > (In reply to Till Schäfer from comment #7) > > 2. The fractional repeat rates below 1 seem to be "rounded" to 0, which > > disables the repeating behavior at all. Which seems a bit unexpected since > > there exist the extra option of disabling repeat above. > > > > For the second case it seem reasonable to round using ceil instead of floor. > There will be "0" position disabling the rate, anyway, so maybe not too > unexpected? > I'm not against it, just asking. The slider is in the interval (0,100] with a lowest repeat rate of 0.2. Thus, under X11, this always causes a repeating behavior. (In reply to Till Schäfer from comment #13) > The slider is in the interval (0,100] with a lowest repeat rate of 0.2. > Thus, under X11, this always causes a repeating behavior. Got it (sorry I don't have my Plasma runnable ATM). I though about rounding to the nearest integer, but maybe ceiling would be better indeed, then. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1586 Git commit 43aec9ca18c850f40bf2c23e461f8bf6ddd87a51 by Vlad Zahorodnii, on behalf of Andrey Butirsky. Committed on 08/11/2021 at 08:37. Pushed by vladz into branch 'master'. fixup! [wayland] fix ignored keyboard RepeatRate Ceiling so that it repeats on minimal 0.x rates accessible via UI M +3 -1 src/keyboard_input.cpp https://invent.kde.org/plasma/kwin/commit/43aec9ca18c850f40bf2c23e461f8bf6ddd87a51 Git commit ac081cad79930a419d413858ca2c3400d571d569 by Vlad Zahorodnii, on behalf of Andrey Butirsky. Committed on 08/11/2021 at 08:41. Pushed by vladz into branch 'Plasma/5.23'. fixup! [wayland] fix ignored keyboard RepeatRate Ceiling so that it repeats on minimal 0.x rates accessible via UI (cherry picked from commit 43aec9ca18c850f40bf2c23e461f8bf6ddd87a51) M +2 -1 src/input.cpp https://invent.kde.org/plasma/kwin/commit/ac081cad79930a419d413858ca2c3400d571d569 It's still broken for me on kwin 5.25.2. Are there any workarounds? I just switched from X11 to Wayland and the low repetition speed is hugely inconvenient. PS. otherwise the Wayland sessions seems pretty solid. Thanks KDE Team! Is this bug really fixed? Today, on Ubuntu 23.10, Konsole 23.08.1, KDE Frameworks 5.110.0 QT 5.15.10 I cannot get key repeat to work at all inside of Konsole. It does not seem to work in any normal KDE app. It does work in Chrome It does not work in GTK apps (Geany) It does not work in Kate How do I make keys repeat with the newest (released) ubuntu Plasma/KDE release, using Wayland ? (Intel gfx) And I should say, BACKSPACE REPEAT WORKS SPACE REPEAT WORKS Character repeat, like holding down - to get ------- DOES NOT WORK God I wish I could edit my comments. In Konsole, SPACE REPEAT DOES NOT WORK ONLY backspace. SPACE AND BACKSPACE both work in Kate wtf Nope, its some sort of toggle... Space forward seems to work for a bit backspace always works space forward seems to stop working after backspacing... |