Summary: | KDE Settings crash when adding custom shortcut *after* removing one | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | John Vincent <corcegajovic> |
Component: | kcm_khotkeys | Assignee: | Michael Jansen <kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nate, plasma-bugs |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.22.5 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/khotkeys/commit/a4137ac8f7b18824568fbee0f3e2dce7551841b7 | Version Fixed In: | 5.23.4 |
Description
John Vincent
2021-10-13 08:11:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/khotkeys/-/merge_requests/17 Git commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d by Harald Sitter. Committed on 15/11/2021 at 06:59. Pushed by sitter into branch 'master'. when deleting an entry, also delete the widgets previously what would happen is that KCMHotkeys::currentChanged would run, find the new index (-1,-1) now invalid and show the global settings instead. this however left the simple_action's underlying widgets still sitting around referring to the previous index AND holding a dangling trigger point that would eventually crash when the simple_action would be poked by anything instead force unset the internal state of the simple_action when showing the global settings. FIXED-IN: 5.23.5 M +3 -0 kcm_hotkeys/kcm_hotkeys.cpp M +11 -7 kcm_hotkeys/simple_action_data_widget.cpp M +3 -0 kcm_hotkeys/simple_action_data_widget.h M +8 -0 kcm_hotkeys/triggers/trigger_widget_base.cpp https://invent.kde.org/plasma/khotkeys/commit/97f9339fd96d97e012347f8f7fca987bbe4fca0d Git commit a4137ac8f7b18824568fbee0f3e2dce7551841b7 by Harald Sitter. Committed on 15/11/2021 at 07:02. Pushed by sitter into branch 'Plasma/5.23'. when deleting an entry, also delete the widgets previously what would happen is that KCMHotkeys::currentChanged would run, find the new index (-1,-1) now invalid and show the global settings instead. this however left the simple_action's underlying widgets still sitting around referring to the previous index AND holding a dangling trigger point that would eventually crash when the simple_action would be poked by anything instead force unset the internal state of the simple_action when showing the global settings. FIXED-IN: 5.23.5 (cherry picked from commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d) M +3 -0 kcm_hotkeys/kcm_hotkeys.cpp M +11 -7 kcm_hotkeys/simple_action_data_widget.cpp M +3 -0 kcm_hotkeys/simple_action_data_widget.h M +8 -0 kcm_hotkeys/triggers/trigger_widget_base.cpp https://invent.kde.org/plasma/khotkeys/commit/a4137ac8f7b18824568fbee0f3e2dce7551841b7 |