Summary: | Git Commit tool view doesn't display git commit errors | ||
---|---|---|---|
Product: | [Applications] kdevelop | Reporter: | Igor Kushnir <igorkuo> |
Component: | VCS: Git | Assignee: | Jonathan Verner <jonathan.verner> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jonathan.verner |
Priority: | NOR | ||
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kdevelop/kdevelop/commit/a99c312f4c7958f59d0ef41cb928f20f0dd44cfd | Version Fixed In: | 5.7.0 |
Description
Igor Kushnir
2021-10-08 12:48:45 UTC
Its on my todo list :-) Git commit 304907339df0f2185e29daacb411a0bed1af6395 by Jonathan L. Verner. Committed on 11/11/2021 at 13:45. Pushed by igorkushnir into branch 'release/21.12'. Enable the commit form after git commit failure This fixes a bug which would lead to the commit form being disabled and unusable when a commit failed for some reason. The commit form was disabled when the commit job started and was meant to be enabled when the job finished. However, the wrong signal was connected to, which meant that in case of failure the code never ran. FIXED-IN: 5.7.0 M +1 -1 plugins/git/committoolview.cpp https://invent.kde.org/kdevelop/kdevelop/commit/304907339df0f2185e29daacb411a0bed1af6395 Git commit a99c312f4c7958f59d0ef41cb928f20f0dd44cfd by Jonathan L. Verner. Committed on 11/11/2021 at 14:59. Pushed by igorkushnir into branch 'release/21.12'. Show an error message in the git commit view when committing fails When committing fails, the user should be informed (and not expected to notice this by seeing an error in the Version Control output view or knowing commit message not being cleared means failure). I opted to use a KMessageWidget instead of a Modal Dialog (per the HIG guidelines, although they are a bit unclear, since there is no clear action that the user can take to remedy the situation). I also opted for just a short message pointing the user to the Version Control output view for more information due to the limited space available in the commit toolview. FIXED-IN: 5.7.0 M +3 -0 plugins/git/committoolview.cpp M +22 -0 plugins/git/simplecommitform.cpp M +19 -0 plugins/git/simplecommitform.h https://invent.kde.org/kdevelop/kdevelop/commit/a99c312f4c7958f59d0ef41cb928f20f0dd44cfd |