Bug 443453

Summary: The arrow that indicates sub-menus changes it's color to white even though it shouldn't
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: Felipe Kinoshita <kinofhek>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: minor CC: ahiemstra, kde, nate, noahadvs
Priority: NOR Keywords: regression
Version First Reported In: 5.86.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Screenshot showing observed result

Description Felipe Kinoshita 2021-10-07 22:05:01 UTC
Created attachment 142244 [details]
Screenshot showing observed result

The arrow that indicates nested items changes it's color to white even though it shouldn't, now that breeze implemented more of blue ocean, highlighted list items' text maintain it's color (black) so the arrow should do the same thing.

STEPS TO REPRODUCE
1. Open some kirigami app that has a nested menu or a menubar (tok, kalendar)
2. hover over some list item that has child items

OBSERVED RESULT
The arrow that indicates it has nested items change it's color to white.

EXPECTED RESULT
The arrow should not change it's color.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora KDE 34
(available in About System)
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Not sure if this is the right product to report this bug to...
Comment 1 Nate Graham 2021-10-08 15:30:54 UTC
It's the right place. :)
Comment 2 Bug Janitor Service 2021-10-08 16:58:13 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/98
Comment 3 Felipe Kinoshita 2021-10-08 22:23:59 UTC
Git commit 87aab00cf5bc0f74ef59f18edee24faab8b67768 by Felipe Kinoshita.
Committed on 08/10/2021 at 21:24.
Pushed by fhek into branch 'master'.

Don't change MenuItem's arrow's color when selected

This makes it more consistent with the new direction we're going
with Breeze, the text color and arrow shouldn't change it's colors
when selected.

As Noah Davis said: "we should really do is change how the selected
effect  is handled. I think that's in KIconThemes. We only support
Breeze in this component right now, so removing that line should work
fine. When we support more styles, then we can add it back."

M  +0    -1    org.kde.desktop/MenuItem.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/87aab00cf5bc0f74ef59f18edee24faab8b67768