|
Description
Björn
2021-10-06 15:08:04 UTC
Can you attach a screenshot of what you think takes too much space? Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! Created attachment 142724 [details]
2 signatures with different space requirements
2 signatures with different space requirements. The first one from "Bjoern Adelberg" is too big.
The problem is that documents are created in which there are certain areas where a signature should be displayed. The document creator plans for a certain size, which is based on the size of certificates from Adobe.
I don't understand the problem. You made the first one, you chose exactly which rectangle you wanted the signature to use, so why did you chose such a huge area instead of a smaller one? Created attachment 146239 [details]
Frame of the signature
This is the frame of a signature (only edited to erase some personal data); if I choose a smaller frame, it complains as it is too small. I do not see a way to change the size of the font. This is done in Fedora 35 with okular-21.12.2 compiled from sources.
(In reply to Enrique Artal from comment #5) > Created attachment 146239 [details] > Frame of the signature > > This is the frame of a signature (only edited to erase some personal data); > if I choose a smaller frame, it complains as it is too small. I do not see a > way to change the size of the font. This is done in Fedora 35 with > okular-21.12.2 compiled from sources. I use the same version 21.12.2 but the problem persists. I did not compile it myself, but from the package manager of my distribution. Is there a way to adjust the font size manually? Hi, to my mind, the signature should auto resize according to the box size. At least this is the behavior in Adobe Reader. And maybe the frame and the gray background can be removed or at least reduced? This is just a visual thing, but in a document with several other Adobe signatures it looks a little bit "lost" ... not sure how to describe it. Oh, and no frame means more space for the signature ^^ I just installed version 22.04.1 of Okular (on an Ubuntu 20.4 platform) and the problem is still there: when I go to Tools-->DigitallySign, I am asked to create a box to hold my signature. If the box is too small, I am asked to re-draw it (but I do not see any indication of how large it should be -- hence I need to go through a few iteration to identify the "optimal" size). My name and the date of signature are then placed in the box but their font is too large. Also, the signature box has a gray background which makes it stand out in a not-so-pleasant way. Can anything be done to control the background colour and the font size used in the signature box? This is a great tool but the issues reported in this ticket really make its use in a professional environment difficult ... Adjusting the font size according to the box size could be a relatively easy way to address this. However I think the overall UX could still be improved. We are asking the user to specify an area where they initially have no idea what size would be appropriate for the content. The the user has to figure out the best size through trial and error. Perhaps we could do something like 1. The user starts signing 2. Okular asks which certificate should be used 3. Based on the certificate content Okular calculates a suggested rectangle and places that somewhere 4. The user can resize and move the rectangle as needed 5. The user saves and the PDF is signed I agree! (In reply to Nicolas Fella from comment #9) > Adjusting the font size according to the box size could be a relatively easy > way to address this. > > However I think the overall UX could still be improved. We are asking the > user to specify an area where they initially have no idea what size would be > appropriate for the content. The the user has to figure out the best size > through trial and error. Perhaps we could do something like > > 1. The user starts signing > 2. Okular asks which certificate should be used > 3. Based on the certificate content Okular calculates a suggested rectangle > and places that somewhere > 4. The user can resize and move the rectangle as needed > 5. The user saves and the PDF is signed Previous versions the signature was a bit smaller. Now it is completely disproportionate especially for long names Created attachment 154616 [details]
example font too big
Attached another example using okular 22.08.3 Created attachment 154617 [details]
Test document with adobe and okular signatures same field size
This is probably fixed by https://invent.kde.org/graphics/okular/-/merge_requests/537 (In reply to Oliver Sander from comment #15) > This is probably fixed by > https://invent.kde.org/graphics/okular/-/merge_requests/537 Hopefully yes. The request is 11 month old though ... Created attachment 154666 [details]
Signature via form field
Signature via form field produces an unreadable visual representation of the digital signature
Created attachment 154667 [details]
Signature via user-specified rectangular area
As reported earlier the static font size in the signature box is too large. Would be nice if that could be adapted dynamically, to fit all content.
This bug should be classified as "CONFIRMED", correct? It's affecting multiple people including myself. My use case is documents that have what I would consider a normally-sized signature area at the bottom. When I sign, all that gets displayed is a huge text version of my first name (see attachment), which looks very unprofessional compared to Adobe digital signatures. Created attachment 158016 [details]
Example of too-large font for digital signature
I'm not sure if this is a bug, or rather a new feature request, but I too would like to have the ability to adjust the size of the digital signature (or ideally, have it auto-resize like Adobe does). When signing a document where other users used Adobe PDF, signatures that were created by Okular are much larger (they stand out like John Hancock's signature would!) In version 23.08.0 there are some nice improvements about digital signature, but the size of the fonts is still very big and non adjustable. Any hope? (In reply to Enrique Artal from comment #22) > In version 23.08.0 there are some nice improvements about digital signature, > but the size of the fonts is still very big and non adjustable. Any hope? It is not currently on *my* work table. What could help this would be a thorough proposal about - What fixed things should be changed - from what and to what. Be specific. - What should be adjustable? - In what dialogs should the adjustability be? How should it look like? Can you visualize it somehow? - What should the work flow be for doing this? And get several of the bug submitters behind it (and preferably also contact KDE's visual design team for support) Currently it is mostly people pulling in various directions and a lot of not-concrete things; if it can somehow be consolidated to a great proposal, it might help on progress. About visualization: I'm not picky. It can be a photo of a piece of paper with lines on. It can be mockup tools. Or kolourpaint. Or it can just be a file from QtDesigner (In reply to Sune Vuorela from comment #23) Thanks for the answer. > (In reply to Enrique Artal from comment #22) > > In version 23.08.0 there are some nice improvements about digital signature, > > but the size of the fonts is still very big and non adjustable. Any hope? > > It is not currently on *my* work table. I understand it; this problem was reported almost two years ago and there are several people that have confirmed it. Any of the attached images by several users show the issue. > > What could help this would be a thorough proposal about > - What fixed things should be changed - from what and to what. Be specific. Apparently when one chooses a frame the size of the fonts does not depend on the size of the frame. As a consequence one has two big letters, not aligned, and even some part of the name. In some documents one can put a large frame to avoid it (though the result is not aestethically optimal) but some other documents have very few space for the frame > - What should be adjustable? One option is that the size of the font is chosen in terms of the size of the frame. The other option is to open a dialog for this choice (as it is now for a background image). I do not know if it is possible to implement it. > - In what dialogs should the adjustability be? How should it look like? For the first choice, it would be internal. For the second one, add one more line in the frame asking you for certificate, location, image, etc. > Can you visualize it somehow? > - What should the work flow be for doing this? I do not know if I can be more helpful, but I would be glad to test any progress. > > And get several of the bug submitters behind it (and preferably also contact > KDE's visual design team for support) > > Currently it is mostly people pulling in various directions and a lot of > not-concrete things; if it can somehow be consolidated to a great proposal, > it might help on progress. > > About visualization: > I'm not picky. It can be a photo of a piece of paper with lines on. It can > be mockup tools. Or kolourpaint. Or it can just be a file from QtDesigner Thanks again, Enrique. Created attachment 161166 [details]
An example for a document with no space limits for the signature. All ok for me.
Created attachment 161167 [details]
An example of a document with a limited heigth for the signature. On the big text part the ID is missing and the name it's cutted.
Created attachment 161168 [details]
The ID and name big text is bigger than expected and the ID text is cutted. You can compare the signature with adobe acrobat it's more beatyfull.
Created attachment 161169 [details]
Another example with the big text name cutted and ID missing.
I just attached 4 real examples. Please take a look. Thank's! (In reply to MarcSerra from comment #29) > I just attached 4 real examples. Please take a look. Thank's! Basically, I encountered all the issues illustrated by Marc; at least you can dance! :) This particular issue has been bothering me for a long while, so I tried to investigate if this could be addressed easily. A quick solution is to add the following line: pData->setFontSize(10); to the following file: https://invent.kde.org/graphics/okular/-/blob/release/23.08/generators/poppler/generator_pdf.cpp#L1382 Side note: After compiling Okular from source (https://okular.kde.org/build-it/) make sure to also update the library path (otherwise system version of the compiled generator_pdf will be called). At this point, I cannot make any pull request, because there are several other things that should be addressed. The font size setting could be added to: https://invent.kde.org/graphics/okular/-/blob/release/23.08/part/selectcertificatedialog.ui However, the "signature is too small" warning dialogue is currently somewhat arbitrary and based on fixed pixel size (https://invent.kde.org/graphics/okular/-/blob/release/23.08/part/pageviewannotator.cpp#L358) so without further changes the user would get the warning even with the smaller font size. A more adaptive solution (font size automatically determined from annotation box size), would probably require changes in the poppler library. I made a merge request at: https://invent.kde.org/graphics/okular/-/merge_requests/839 For me, the font size is the greatest issue, since in Brazil with university ICP-EDU RNP certificates, the Full Name is connected with the national number (called CPF), that has 11 digits... So, the left side is typically giant and broken, unless a very large space is provided. I created two tutorials that have been used in brazilian universities, and they explain exactly about this problem (but in Portuguese): - https://igormcoelho.medium.com/assinatura-digital-do-icpedu-em-pdf-no-gnu-linux-c612688ce454 - https://igormcoelho.medium.com/assinatura-digital-do-icpedu-com-carimbo-utilizando-okular-98c146066c3a I also created some PDF with "enough space" for the current signature system, which is quite large: - https://raw.githubusercontent.com/igormcoelho/igormcoelho/main/tutoriais/2021-Teste-Assinatura-Digital.pdf A solution, at least for me, is to allow to reduce font size when selecting the Stamp box for signature (together with fields Reason, etc, one could select "Font Size: 20" or "Font Size: XX"). There are multiple scenarios to consider here: 1) Singing a predefined signature field. Here the size is fixed and currently we risk cutting off the text because it is too large. The font size should automatically be chosen so that the text fits into the predefined box 2) We add a new signature to the document. Here we get to choose the bounding box, but we have to consider that space on the document may be limited. Ideally we would have something like I described in https://bugs.kde.org/show_bug.cgi?id=443403#c9 - When adding a signature we collect the necessary information - Then we calculate a reasonable suggested bounding box and place that somewhere on the document - Then the user is able to move and resize the proposed signature as they desire. When resizing the font scales appropriately so that the text always fits - The user hits "Apply" of some sort and the signature is baked into the signed document A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/965 A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/966 Git commit 465b9ff5cea0cc4d4f35308ac1bb3d84a912cda9 by Nicolas Fella. Committed on 15/04/2024 at 12:24. Pushed by nicolasfella into branch 'master'. Let poppler pick the font size when signing signature fields Currently we use the default font sizes for NewSignatureData, which are 10 for fontSize and 20 for leftFontSize This can be too large for a small signature field, leasing to cut-off text When passing 0 poppler picks a suitable size depending on the size of the signature field M +5 -0 generators/poppler/formfields.cpp https://invent.kde.org/graphics/okular/-/commit/465b9ff5cea0cc4d4f35308ac1bb3d84a912cda9 A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/1005 Git commit e165180bb0db38e780e7fcd425cff186f48abd12 by Nicolas Fella. Committed on 12/09/2024 at 12:54. Pushed by aacid into branch 'master'. Rework UX for adding digital signature Currently when adding a signature the user is prompted to specify a rectangle, then chose a certificate. The problem here is that the user doesn't know what size is appropriate, so it takes some trial and error to get something good. To address this change the flow a bit. First ask which certificate and other parameters should be used. With that information we create a signature annotation object and add that to the page. The user can then move and resize it like any annotation util the size and placement is right. Once the user is happy with the placement they click on a Finish Signing button that then prompts for where to save the signed document and signs it. This makes the warning about a too small signature rect redundant since the user sees that the signature won't fit. It was only an approximation anyway. M +6 -0 CMakeLists.txt M +133 -0 core/annotations.cpp M +56 -0 core/annotations.h M +6 -0 core/document.cpp M +5 -0 core/document.h M +8 -0 core/signatureutils.h M +50 -0 generators/poppler/annots.cpp M +47 -1 part/pageview.cpp M +10 -0 part/pageview.h M +133 -45 part/pageviewannotator.cpp M +4 -0 part/pageviewannotator.h M +23 -0 part/part.cpp M +6 -0 part/part.h M +1 -0 shell/shell.cpp https://invent.kde.org/graphics/okular/-/commit/e165180bb0db38e780e7fcd425cff186f48abd12 A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/1053 |