| Summary: | [feature] Latte should have an option for theme's defined opacity/mask/style | ||
|---|---|---|---|
| Product: | [Unmaintained] lattedock | Reporter: | doncbugs |
| Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | mvourlakos |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/latte-dock/commit/899c0155c7ebc2114e2a855055ef3fa92dbb09f7 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
latte does not allow for knowing panel's original appearance
default does not look like the plasma panel this theme's panel background breaks Def. setting |
||
Latte now works with desktop themes and allows preconfiguring the layout. (In reply to doncbugs from comment #1) > Latte now works with desktop themes and allows preconfiguring the layout. what you mean? https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1243 Does this not allow specifying settings for latte-dock auto-magically? (In reply to doncbugs from comment #3) > https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1243 > > Does this not allow specifying settings for latte-dock auto-magically? It allows to load a full latte layout that is present inside the LookNFeel package Git commit d841e1e443a95cf74503580f45ca494738fc7182 by Michail Vourlakos. Committed on 25/02/2022 at 16:34. Pushed by mvourlakos into branch 'master'. provide Default option for Background opacity --the user can now move the background opacity slider to the farest left side and is such case it will get the plasma theme default opacity. This is the same way that background radius and shadows size can return to default settings M +1 -1 containment/package/contents/config/main.xml M +2 -1 containment/package/contents/ui/abilities/privates/MyViewPrivate.qml M +2 -2 shell/package/contents/configuration/pages/AppearanceConfig.qml https://invent.kde.org/plasma/latte-dock/commit/d841e1e443a95cf74503580f45ca494738fc7182 Created attachment 150149 [details]
default does not look like the plasma panel
This appears to be broken in latte-git. Default and 0 appear to have the same effect.
The difference in saturation may be an indicator that latte is also ignoring plasma theme's Contrast Effect settings.
(In reply to doncbugs from comment #6) > Created attachment 150149 [details] > default does not look like the plasma panel > > This appears to be broken in latte-git. Default and 0 appear to have the > same effect. > > The difference in saturation may be an indicator that latte is also ignoring > plasma theme's Contrast Effect settings. you need opacity to Default. Created attachment 150157 [details] this theme's panel background breaks Def. setting (In reply to Michail Vourlakos from comment #7) > you need opacity to Default. Yes, I'm saying it was set to Default. The screenshot attached is latte-dock with opacity set to "default". Okay, I see that something about the theme I am using causes latte to behave strangely. Try this: 1. Enable Background Contrast setting in System settings > Workspace Behavior > Desktop effects > Background Contrast ON 2. Set plasma theme to "sumac min" (attached) 3. Set dock appearance to "Def." 4. Set dock appearance to "1%" 5. Set dock appearance to "0%" Strange, no? 1% looks like Def. Def. looks like 0%. Git commit 54ccf51cdab1a337d69e6dc7848a4ab346f39051 by Michail Vourlakos. Committed on 26/06/2022 at 06:36. Pushed by mvourlakos into branch 'master'. view:respect plasma theme default opacity value --when background contrast effect is enabled and the user has chosen DEFAULT opacity for its background then plasma theme preferred contrast effect values should be used. M +13 -6 app/view/effects.cpp M +1 -1 containment/package/contents/ui/BindingsExternal.qml https://invent.kde.org/plasma/latte-dock/commit/54ccf51cdab1a337d69e6dc7848a4ab346f39051 should be fine, please test it I think I may finally understand why the theme breaks latte dock. Do you think it's because the assets have 0% opacity backgrounds? I think following the Contrast Effect should be a checkbox in "Appearance > Background" I'm using latte-git 54ccf51. Using the theme I attached, the behavior looks about the same. The original panel-background svgs are 0% opacity with a white 15% outline. With Def. opacity, the white outline is not visible. The Contrast Effect is visible. With 0% opacity, the white outline is not visible. The Contrast Effect is not visible. With 1% opacity, the white outline is visible. The Contrast Effect is visible. The panel looks similar to the plasma panel. (In reply to doncbugs from comment #11) > I think I may finally understand why the theme breaks latte dock. Do you > think it's because the assets have 0% opacity backgrounds? > > I think following the Contrast Effect should be a checkbox in "Appearance > > Background" > not gonna happen > I'm using latte-git 54ccf51. Using the theme I attached, the behavior looks > about the same. > > The original panel-background svgs are 0% opacity with a white 15% outline. > send a link with the plasma desktop theme in question > With Def. opacity, the white outline is not visible. The Contrast Effect is > visible. > > With 0% opacity, the white outline is not visible. The Contrast Effect is > not visible. > > With 1% opacity, the white outline is visible. The Contrast Effect is > visible. The panel looks similar to the plasma panel. for 0% and 1% I am not really interested how contrast effect is handled, I am interested only to provide a sane opacity slider. For the Default option if it does not look like plasma panel looks then this can be addressed. Git commit 899c0155c7ebc2114e2a855055ef3fa92dbb09f7 by Michail Vourlakos. Committed on 27/06/2022 at 09:41. Pushed by mvourlakos into branch 'master'. plasmatheme:define max background opacity to 1% M +6 -0 app/plasma/extended/panelbackground.cpp M +3 -0 containment/package/contents/ui/background/MultiLayered.qml https://invent.kde.org/plasma/latte-dock/commit/899c0155c7ebc2114e2a855055ef3fa92dbb09f7 Ok, the new fix should be now ok with your theme (In reply to doncbugs from comment #11) > I think I may finally understand why the theme breaks latte dock. Do you > think it's because the assets have 0% opacity backgrounds? > yes, the fact that your panel background is fully transparent was making Latte to calculate that your theme maximum opacity was 0% > With Def. opacity, the white outline is not visible. The Contrast Effect is > visible. this is now fixed > > With 0% opacity, the white outline is not visible. The Contrast Effect is > not visible. of course this is the case, when the user uses opacity 0% means that does not want any background to be drawn but at the same time he could choose to enable latte options of shadows and outline > > With 1% opacity, the white outline is visible. The Contrast Effect is > visible. The panel looks similar to the plasma panel. yes, this is fine now also with the new fix Yep, that patch looks like it fixed it. It does still show the outline at 1%, but I think that's a feature. This looks like a good state for latte. |
Created attachment 142180 [details] latte does not allow for knowing panel's original appearance SUMMARY Latte should have an option to display the panel's theme in its default state(s). I.e. it should be possible to show latte dock like how it looks in the plasma panel. Just like having the original shadows and the original corner radius, the original opacity should also be an option. The blur mask seems to be harmed the most when Latte decides the mask instead of the theme. Since the blur area has hard edges and isn't anti-aliased, the correct mask resides slightly inside the original shape. When set to default radius, Latte should have the option to use the theme's mask instead of trying to create its own. STEPS TO REPRODUCE 1. Choose a plasma theme with rounded corners OBSERVED RESULT - There is no way to know what the theme is supposed to look like. Only the plasma panel can show what the theme-maker wanted it to be. For latte, you have to guess what the best opacity might have been. - The blur mask is drawn all the way to the translucent pixels on the dock's corners. For theme's that have well-made/custom blur masks, Latte does not provide a way to use them. EXPECTED RESULT Just like using the theme's shadows and corners, there should be a way to make everything look default. There should be an option to use the default opacity.