| Summary: | Separator between main views looks too short when using a theme without header and footer graphics | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | doncbugs |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | minor | CC: | marcwallington, mikel5764, nate, niccolo, plasma-bugs-null |
| Priority: | LO | Keywords: | regression |
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=442661 | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | separator line now has large top and bottom space | ||
Interesting issue. Sorta-kinda a regression from the fix for Bug 442661. I suppose in this case we could maybe try to detect that and make the separator span the full height of the dialog. Not sure how we would do that though. Right now I think this is just intentional, there's no way around it. The theme could provide at least a bottom/top line for the header/footer to anchor to; but it's IMO a bad idea to dynamically change the position and size of elements depending on whether they implement such line or not. Even on themes without a heading, that separator is meant to distinguish the left and right views, so it cannot extend further; it's the theme's choice to let the left and right views have no top and bottom separator. |
Created attachment 142104 [details] separator line now has large top and bottom space SUMMARY The separator in Kickoff has been changed to look continuous with the header and footer. However, when headers and footers are absent from a theme, the line is just awkwardly placed where it might normally connect, assuming that the header and footer style were wireframe like the line svg. STEPS TO REPRODUCE 1. Apply a theme without a plasmoidheading svg 2. Open Kickoff 3. OBSERVED RESULT Line is drawn separating the two panes with very large margins above and below it. EXPECTED RESULT Line should probably look similar to how it previously did and go from top to bottom. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION Upon writing this, the line may be problematic since it assumes that the theme has the wireframe appearance Breeze has instead of any other style.