Bug 443097

Summary:	Export GUI: Ugly gaps between GUI elements with certain board layouts.
Product:	[Applications] krita	Reporter:	Emmet O'Neill <emmetoneill.pdx>
Component:	Storyboard	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	minor	CC:	danje1, halla
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Emmet O'Neill 2021-09-29 01:10:24 UTC

There's a small graphical bug in the Storyboard Export GUI.

Depending on the "Board Layout" combobox selection we're hiding the widgets for "Rows", "Columns", and "SVG Template Path" parameters. 

There's some padding or something between the elements that's being added even when elements are hidden, and it changes the gap between the UI elements in an annoying way.

Comment 1 Daniel Fichtner 2022-07-16 18:51:42 UTC

I see it. It's not only changing the spacing between the widgets, also the text infront of them jumps around.

I'll have a look and try to make it better :)

Comment 2 Daniel Fichtner 2022-07-17 10:31:23 UTC

So at the moment it uses QFormLayout and depending on the entry in the "Board Layout" ComboBox, labels and comboxes are hidden or shown. The problem is that it's not the row of the QFormLayout that is hidden. Hence, it's still there and adds a little space between the remaining widgets.

Qt 6.4 will introduced QFormLayout::setRowVisible() (https://bugreports.qt.io/browse/QTBUG-6864) which is the solution for exactly this special case. At the moment I could "reproduce it with a QGridLayout to look the same. Or we wait until we have this function?

Also I might hack something up..

Comment 3 Emmet O'Neill 2023-01-06 04:32:43 UTC

Setting this back to "confirmed" for now because it hasn't had active development in a while. When someone jumps back in we can reassign it, but I'm just doing a bit of housecleaning right now.