Bug 443062

Summary: spin box for time fields always increases time value
Product: [Applications] kalarm Reporter: boski_cinek
Component: generalAssignee: David Jarvie <djarvie>
Status: RESOLVED FIXED    
Severity: normal CC: nate, noahadvs
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 21.08.3
Sentry Crash Report:
Attachments: kalarm spinbox issue
Kalarm spinbox with Oxygen theme showing 4 buttons

Description boski_cinek 2021-09-28 09:38:43 UTC
I've noticed this in KAlarm, but it's probably general issue.
Steps to reproduce:
1. Open KAlarm
2. Click "New"
Spinboxes for adjusting alarm time which use "HH:MM" format shows as "[∨][HH:MM][∧]", but both buttons *increase* time value: "[∧]" increases minutes value (as expected) and "[∨]" increases hours value.
Expected behaviour: "[∨]" button should decrease time value.


Operating System: Kubuntu 21.04
KDE Plasma Version: 5.22.90
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-09-28 20:19:21 UTC
The behavior of the buttons is determined by the app. Can you reproduce this issue in any other apps? Or can you only get it to happen in KAlarm?
Comment 2 boski_cinek 2021-09-29 08:56:17 UTC
I could try, but I can't think of any other app that would use "HH:MM" format spin box.
Comment 3 Bug Janitor Service 2021-10-14 04:35:22 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 David Jarvie 2021-10-18 10:00:53 UTC
This works correctly on my system. First of all, can you confirm that both spinboxes, on each side of the control, each contain both an up arrow and down arrow (making 4 up/down arrows in total). Your report appears to suggest ("[∨][HH:MM][∧]") that there is just a down arrow for hours, and an up arrow for minutes.

Assuming that you actually see 4 arrows in the control, the bug may depend on which icon theme you are using, so can you please say which icons are you using? (Go to System Settings -> Appearance -> Icons to find out.)

Can you please attach a screenshot of your alarm time control.
Comment 5 boski_cinek 2021-10-18 11:56:05 UTC
Created attachment 142574 [details]
kalarm spinbox issue
Comment 6 boski_cinek 2021-10-18 12:02:29 UTC
I don't think it depends on icon theme, but it does depend on application style. It looks this is issue specific to new Breeze theme (blue ocean). There were 4 buttons visible in previous Breeze incarnation and I also get 4 buttons after switching to Oxygen theme.
Comment 7 boski_cinek 2021-10-18 12:03:34 UTC
Created attachment 142575 [details]
Kalarm spinbox with Oxygen theme showing 4 buttons
Comment 8 David Jarvie 2021-10-18 13:53:39 UTC
Thank you - I see the issue now. Working on a fix...
Comment 9 David Jarvie 2021-10-20 16:08:44 UTC
In application styles where spinboxes have the up arrow above the down arrow, KAlarm's time edit field adds a second pair of arrows on the other side of the spinbox to adjust the hour value. In Breeze, the up and down arrows are on either side of the spinbox, so it isn't practical to add an extra pair of arrows - doing so was causing the bug. The extra arrows are no longer added in Breeze, and the hour value can now be changed by pressing Control when the mouse is clicked on the arrows.

It is now fixed by commits b6060e197ea4e76db788a39acf13098db5d9a303, 873e617e490f7aab4b5631c1c5ab704ddfee0eeb, e59b9c7e2e6791f1a0f95fa3b998a2fc7ea000e2, and will be in KAlarm version 3.3.2, which will be included in KDE apps release 21.08.3.