Bug 443045

Summary:	Left-clicking with crop tool after crop action undoes last crop
Product:	[Applications] krita	Reporter:	tomtomtomreportingin
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	normal	CC:	shzam
Priority:	NOR
Version First Reported In:	5.0.0-beta1
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description tomtomtomreportingin 2021-09-28 01:43:23 UTC

SUMMARY
For some reason, after a crop action is done, left-clicking on the canvas with the crop tool will not only create a crop box encompassing the whole image, but it will also undo the last crop if it's the last item on the undo stack. The user can Redo this unexpected crop. It happens regardless if the crop action shrunk or grew the canvas.

Not a regression of Krita 5.

STEPS TO REPRODUCE
1. Create an image.
2. Select the crop tool and crop any portion.
3. Left-click after crop.

OBSERVED RESULT
The last crop has been undone.

EXPECTED RESULT
No undo action should occur on left-click.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.12.11 (Appimage)

Comment 1 sh_zam 2021-09-29 11:13:27 UTC

Hello!

I found out what you describe is an intentional behavior: https://docs.krita.org/en/reference_manual/tools/crop.html#continuous-crop and the commit which introduces this: https://invent.kde.org/graphics/krita/-/commit/7c06156a5ce7d2b6925977e73517d70db5959567