| Summary: | Button to configure Breeze window decoration is greyed out | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_kwindecoration | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, nate, plasma-bugs-null |
| Priority: | VHI | Keywords: | regression |
| Version First Reported In: | git-master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/commit/1022ce0036a5e3b77bc274204720d1583b47916e | Version Fixed/Implemented In: | 5.24 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
|
Description
Patrick Silva
2021-09-26 12:12:36 UTC
Created attachment 141920 [details]
screenshot
Possibly related to the fix for Bug 440786, maybe? In any event, cannot reproduce. Oh, I was looking at the widget style and not the decoration style. Can reproduce. Patrick, do you see this in the Plasma 5.23 beta too? It only seems to affect Breeze, not other themes. So I bisected Breeze back to February and didn't come up with anything; trying to KWin now. Bisected to this KWin commit: commit 08d3ceb024ff00d48ef8ffd5587c61ce1c5e06eb Author: Alexander Lohnau <alexander.lohnau@gmx.de> Date: Mon Aug 23 19:39:17 2021 +0200 Port to new KDecoration2::DecorationThemeProvider class By supporting all the required attributes in the DecorationThemeMetaData class the custom struct can be dropped. Task: https://phabricator.kde.org/T14744 src/kcmkwin/kwindecoration/decorationmodel.cpp | 70 +++++++++--------------- src/kcmkwin/kwindecoration/decorationmodel.h | 10 +--- src/plugins/kdecorations/aurorae/src/aurorae.cpp | 33 +++++++---- src/plugins/kdecorations/aurorae/src/aurorae.h | 19 ++++--- 4 files changed, 59 insertions(+), 73 deletions(-) Which means it's in the beta. Alexander, could you take a look? Thanks! (In reply to Nate Graham from comment #3) > Patrick, do you see this in the Plasma 5.23 beta too? I'm unable to reproduce on Arch Linux running Plasma 5.23 beta. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1471 Git commit 1022ce0036a5e3b77bc274204720d1583b47916e by Nate Graham, on behalf of Alexander Lohnau. Committed on 28/09/2021 at 23:08. Pushed by ngraham into branch 'master'. Fix condition for making themes configurable KPluginMetaData::findPlugins only returns valid json metdata, the previous check was accidentally kept for the condition that the plugin provides a theme engine. FIXED-IN: master M +3 -3 src/kcmkwin/kwindecoration/decorationmodel.cpp https://invent.kde.org/plasma/kwin/commit/1022ce0036a5e3b77bc274204720d1583b47916e |