| Summary: | Wrong microphone icon size used in Audio Volume when it exists in plasma style | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma-pa | Reporter: | doncbugs |
| Component: | applet | Assignee: | David Rosca <nowrep> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | minor | CC: | nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.22.90 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
speakers using correct icon size while microphone uses largest
icon sizes color-coded to show which icon is being selected |
||
This is a Plasma applet, and Plasma buttons preferentially use icons in the Plasma theme over icons in the icon theme. If your Plasma theme has a combination of icons that make this look ugly, you should report it to them and ask them to either improve their icons, or else remove them so that the applet falls back to using icons in the icon theme rather than the Plasma theme. Created attachment 141974 [details]
icon sizes color-coded to show which icon is being selected
Sorry, let me clarify. I am a theme maker and this worked properly in the past. What I am describing is that, microphone.svg and audio.svg are both present in the theme and both contain 16-16 variants of their respective icon. However, since the audio slider rework, the mute button for microphone does not appear to respect the appropriate icon size, but the audio mute button does. Interesting, thanks. I see that for the speaker mute icon, we're using the "audio-volume" icon as the base icon, while for microphone mute, we're using "microphone-sensitivity" as the base. So the name of the mute icon would have to be "microphone-sensitivity-muted". Does that match up with the icon names in your theme? I see that we actually don't have that icon in the Breeze Plasma theme, so it's falling back to using the icon from the icon theme instead. Yes, but upon further inspection, I believe a faulty svg may have been the source of the problem. I literally copied and pasted the icons into the svg of a theme that was working and now it seems to work. I am not sure why it suddenly stopped working. Perhaps this is more an issue for how svgs are read. In any case, this can be closed, as the applet appears to work fine. OK great! |
Created attachment 141910 [details] speakers using correct icon size while microphone uses largest SUMMARY At some point during the audio slider rework, it appears the way of selecting the appropriate icon size for the microphone mute button changed. Now, when microphone.svg is present in a plasma style's icons, the smaller icon is not used. The speakers mute button does not appear to have this problem. STEPS TO REPRODUCE 1. Apply a style with a "microphone" icon in its "icons/" directory (I used the Malice theme) 2. Run plasmashell --replace to properly update icons 3. Open Audio Volume on a device with microphone enabled OBSERVED RESULT The microphone icon is very fuzzy and clearly not using the 16x16 version of the icon. The speakers mute button will be using its proper 16x16 version. EXPECTED RESULT The microphone icon should be the 16x16 version, just as the speakers button. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.22.90 KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION