Summary: | Klipper doesn't show that there are images in the clipboard when they're added via wl-copy | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Thiago Sueto <herzenschein> |
Component: | Clipboard | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nate |
Priority: | NOR | Keywords: | wayland |
Version: | git-master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/756d5c51c999df6ec324b794a4eefc9d42e33032 | Version Fixed In: |
Description
Thiago Sueto
2021-09-25 01:58:56 UTC
>Klipper itself does not show that the image is in the clipboard.
Please confirm your klipper settings do not have "ignore images" set.
Actually "Ignore images" was set, but disabling it didn't make a difference. I also did a full relogin and reboot to confirm, just in case. Indeed. It's failing here: else if (data->hasImage()) { despite having the format image/png Urgh, because some magic happens in QInternalMimeData which we don't inherit from. We'll need to either use QPlatformHeaders (which is naughty but easy) or copy and paste the relevant image code for: has_format/formats/retrieveData (~100 lines) A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1208 Git commit 756d5c51c999df6ec324b794a4eefc9d42e33032 by Méven Car, on behalf of Méven Car. Committed on 24/11/2021 at 13:46. Pushed by meven into branch 'master'. Use KGuiAddons::KSystemClipboard to better handle wayland Allow klipper to read image data from clipboard M +3 -5 klipper/CMakeLists.txt M +3 -4 klipper/klipper.cpp M +2 -2 klipper/klipper.h D +0 -27 klipper/systemclipboard/CMakeLists.txt D +0 -31 klipper/systemclipboard/qtclipboard.cpp D +0 -17 klipper/systemclipboard/qtclipboard.h D +0 -34 klipper/systemclipboard/systemclipboard.cpp D +0 -47 klipper/systemclipboard/systemclipboard.h D +0 -5 klipper/systemclipboard/tests/CMakeLists.txt D +0 -33 klipper/systemclipboard/tests/paste.cpp D +0 -424 klipper/systemclipboard/waylandclipboard.cpp D +0 -25 klipper/systemclipboard/waylandclipboard.h D +0 -278 klipper/systemclipboard/wlr-data-control-unstable-v1.xml https://invent.kde.org/plasma/plasma-workspace/commit/756d5c51c999df6ec324b794a4eefc9d42e33032 |