| Summary: | Exporting in Story Board docker when there is no scene in it crashes Krita | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Dockers | Assignee: | Emmet O'Neill <emmetoneill.pdx> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | eoinoneill1991, halla |
| Priority: | NOR | ||
| Version First Reported In: | 5.0.0-beta1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/1641fe316e875b413f0321735740ab329cec7019 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Tyson Tan
2021-09-19 15:05:52 UTC
Is this that got fixed in the storyboard work recently? If so -- I guess that work should be backported to krita/5.0? I don't think so? I was testing this using: krita-5.1.0-prealpha-7699e8a-x86_64.appimage Now with krita-5.0.0-beta1-0986afa-x86_64.appimage Krita always crashes no matter what when exporting from Story Board docker. Git commit a3676628e37fc612e5014368400b6af0f6cabf27 by Eoin O'Neill. Committed on 22/09/2021 at 22:20. Pushed by eoinoneill into branch 'master'. Storyboard exporting no longer possible when there's no content. The button shouldn't be clickable when there's no storyboard content to export -- it just wouldn't make a lot of sense that way! M +11 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.cpp M +5 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.h https://invent.kde.org/graphics/krita/commit/a3676628e37fc612e5014368400b6af0f6cabf27 Git commit 2a5950456bcde2b0fe55557ff8512612b3edfe3f by Eoin O'Neill. Committed on 22/09/2021 at 22:18. Pushed by eoinoneill into branch 'master'. Fix crash when trying to export storyboard without scenes. We also prevent the export window from opening at all when there's no storyboard content available now. Lastly, in the odd chance the window does open, we make sure it won't crash due to divide by zero. We will disable the export button to reflect that this isn't possible when there's nothing to export in a later commit. M +3 -3 plugins/dockers/storyboarddocker/DlgExportStoryboard.cpp M +2 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.cpp https://invent.kde.org/graphics/krita/commit/2a5950456bcde2b0fe55557ff8512612b3edfe3f Thanks for reporting the bug Tyson. It should be solved in the nightly now. Thank you Eoin! :D Git commit 35edfb69d7891fc70ee7fb6358dce8e4b3a82091 by Eoin O'Neill. Committed on 27/09/2021 at 20:15. Pushed by eoinoneill into branch 'krita/5.0'. Storyboard exporting no longer possible when there's no content. The button shouldn't be clickable when there's no storyboard content to export -- it just wouldn't make a lot of sense that way! (cherry picked from commit a3676628e37fc612e5014368400b6af0f6cabf27) M +11 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.cpp M +5 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.h https://invent.kde.org/graphics/krita/commit/35edfb69d7891fc70ee7fb6358dce8e4b3a82091 Git commit 1641fe316e875b413f0321735740ab329cec7019 by Eoin O'Neill. Committed on 27/09/2021 at 20:14. Pushed by eoinoneill into branch 'krita/5.0'. Fix crash when trying to export storyboard without scenes. We also prevent the export window from opening at all when there's no storyboard content available now. Lastly, in the odd chance the window does open, we make sure it won't crash due to divide by zero. We will disable the export button to reflect that this isn't possible when there's nothing to export in a later commit. (cherry picked from commit 2a5950456bcde2b0fe55557ff8512612b3edfe3f) M +3 -3 plugins/dockers/storyboarddocker/DlgExportStoryboard.cpp M +2 -0 plugins/dockers/storyboarddocker/StoryboardDockerDock.cpp https://invent.kde.org/graphics/krita/commit/1641fe316e875b413f0321735740ab329cec7019 |