Bug 442692

Summary:	Edited sensor label should be applied when we press enter/return
Product:	[Plasma] plasmashell	Reporter:	Patrick Silva <bugseforuns>
Component:	System Monitor widgets	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	ahiemstra, mrfrh, nate, notmart, oded
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.24.90
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Patrick Silva 2021-09-19 12:55:10 UTC

SUMMARY
We can edit the label of system monitor sensors, but currently we are forced to click on a button to apply the editing. If we try to apply the editing by pressing enter/return, the widget settings is closed and the editing is not applied.  

EXPECTED RESULT
we are able to apply edited sensor label by pressing enter/return

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.23.80
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.3
Graphics Platform: Wayland

Comment 1 Oded Arbel 2022-02-22 15:03:53 UTC

Had the same issue, so I wanted to report it (and found this report instead) but now I can't reproduce the issue: there was no system update and I didn't even restart, but now when I press the edit button on a sensor label, type something and press ENTER - it accepts the change and does not close the configuration dialog.

I think it may be related to the fact that just before that I opened the system monitor application, went to a custom page and edited some sensor labels (basically to check how this functions in the full app), where pressing ENTER just applied the label as expected - and now the system monitor widget just works. 🤷

Comment 2 Patrick Silva 2022-02-22 15:31:33 UTC

I can reproduce on neon unstable even after editing a sensor label in the System Monitor app.

Comment 3 Oded Arbel 2022-02-22 15:37:53 UTC

After adding a new system monitor widget, the behavior reverted to the broken behavior with ENTER closing the dialog, and I can't repro the workaround - the sensor label in the system monitor application works fine, in the widget configuration dialog it doesn't.

Comment 4 Patrick Silva 2023-01-21 21:53:03 UTC

*** Bug 464599 has been marked as a duplicate of this bug. ***

Comment 5 Patrick Silva 2023-11-13 17:41:57 UTC

On Plasma 6 alpha, the settings window does not close after editing the sensor label and then pressing enter/return. :)

Operating System: Arch Linux 
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.245.0
Qt Version: 6.6.0
Graphics Platform: Wayland